Page MenuHomePhabricator
Differential D6745

[web] Split ThreadTopBar into two components
ClosedPublic
Actions

Authored by inka on Feb 16 2023, 6:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 5:22 AM
Unknown Object (File)
Thu, Nov 21, 5:22 AM
Unknown Object (File)
Tue, Nov 19, 10:01 AM
Unknown Object (File)
Tue, Nov 19, 10:01 AM
Unknown Object (File)
Tue, Nov 19, 10:01 AM
Unknown Object (File)
Tue, Nov 19, 10:01 AM
Unknown Object (File)
Tue, Nov 19, 9:59 AM
Unknown Object (File)
Tue, Nov 19, 9:36 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
• kuba
kamil
Commits
rCOMM24839908bd81: [web] Split ThreadTopBar into two components
Summary

Issue: https://linear.app/comm/issue/ENG-2740/add-navigation-state-info-to-the-top-bar
Navigation state info will be displayed in the Topbar component. It used to be in ChatMessageList container. Now, in ChatListContainer we will only display the name of the chat.
I split ThreadTopBar component into two: the one that will be displayed in the Tobbar, that includes the ThreadAncestors, but doesn't have the ThreadMenu, and a complementary component, that is used in the
ChatMessageListContainer. I will change the NavStateInfoBar further, accordinng to the designs, in the following diffs.
Some files were additionally moved to keep the code correctly divided into folders.

image.png (1×1 px, 139 KB)

Test Plan

Run web app, checked that the header of ChatMessageListContainer displays only chat's: name, colour square and menu button. I also exchanged ThreadTopBar in ChatMessageListContainer for NavStateInfoBar and check that is displays correctly:

image.png (1×1 px, 144 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Feb 16 2023, 6:34 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 16 2023, 6:34 AM
inka edited the summary of this revision. (Show Details)Feb 16 2023, 6:35 AM
inka edited the test plan for this revision. (Show Details)Feb 16 2023, 6:37 AM
inka updated this revision to Diff 22650.Feb 16 2023, 6:42 AM

Fix props types names

Harbormaster completed remote builds in B16553: Diff 22649.Feb 16 2023, 6:51 AM
inka added a parent revision: D6741: [web] Move logic for fetching ThreadInfo for possibly pending chat out of ChatMessageListContainer component.Feb 16 2023, 6:53 AM
inka added a child revision: D6746: [web] Add a selector for getting the item currently selected in the drawer.
Harbormaster completed remote builds in B16554: Diff 22650.Feb 16 2023, 6:58 AM
inka requested review of this revision.Feb 16 2023, 6:58 AM
inka updated this revision to Diff 22857.Feb 21 2023, 7:16 AM

Rebase

Harbormaster failed remote builds in B16704: Diff 22857!Feb 21 2023, 7:32 AM
Harbormaster completed remote builds in B16704: Diff 22857.Feb 21 2023, 7:52 AM
inka added a child revision: D6841: [web] Add PossiblyEmptyNavStateInfoBar to handle collapse animation in the topbar when no community is selected.Feb 23 2023, 1:00 AM
inka removed a child revision: D6841: [web] Add PossiblyEmptyNavStateInfoBar to handle collapse animation in the topbar when no community is selected.
inka mentioned this in D6851: [web] Fix long names in displaying incorrectly in the ChatMessageListContainers header.Feb 23 2023, 6:19 AM
michal accepted this revision.Mar 2 2023, 2:29 AM
michal added inline comments.
web/navigation-panels/nav-state-info-bar.react.js
25–34

We don't use threadMenu here so could we simplify the topBarContainer and topBarThreadInfo divs and css classes into one?

This revision is now accepted and ready to land.Mar 2 2023, 2:29 AM
inka added inline comments.Mar 13 2023, 4:01 AM
web/navigation-panels/nav-state-info-bar.react.js
25–34

Sure, but I'll fix this in D6841 to avoid unnecessary rebase conflicts.

inka added inline comments.Mar 13 2023, 4:05 AM
web/navigation-panels/nav-state-info-bar.react.js
25–34

Or actually in D6845, which is a diff styling the top bar, so it makes sense

Closed by commit rCOMM24839908bd81: [web] Split ThreadTopBar into two components (authored by • InkaSokolowska). · Explain WhyMar 13 2023, 6:35 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM24839908bd81: [web] Split ThreadTopBar into two components.
• InkaSokolowska mentioned this in rCOMM5339cf4c28f1: [web] Fix long names in displaying incorrectly in the ChatMessageListContainers….

Revision Contents
Changeset List

Diff 22857

View Options

web/chat/chat-thread-ancestors.css

Loading...
View Options

web/chat/chat-thread-ancestors.react.js

Loading...
View Options

web/chat/thread-top-bar.react.js

Loading...
View Options

web/navigation-panels/chat-thread-ancestors.css

Loading...
View Options

web/navigation-panels/chat-thread-ancestors.react.js

Loading...
View Options

web/navigation-panels/nav-state-info-bar.css

Loading...
View Options

web/navigation-panels/nav-state-info-bar.react.js

Loading...