Differential D6851

[web] Fix long names in displaying incorrectly in the ChatMessageListContainers header
ClosedPublic
Actions

Authored by inka on Feb 23 2023, 6:18 AM.

Tags

None

Referenced Files

	F3537721: D6851.id23687.diff
	Wed, Dec 25, 10:11 PM

	F3537719: D6851.id22997.diff
	Wed, Dec 25, 10:11 PM

	F3537648: D6851.id.diff
	Wed, Dec 25, 10:10 PM

	F3537556: D6851.diff
	Wed, Dec 25, 9:59 PM

	Unknown Object (File)
	Nov 19 2024, 10:01 AM

	Unknown Object (File)
	Nov 19 2024, 10:01 AM

	Unknown Object (File)
	Nov 19 2024, 9:59 AM

	Unknown Object (File)
	Nov 19 2024, 9:36 AM

Subscribers

Details

Reviewers

michal
• kuba
bartek

Commits

rCOMM5339cf4c28f1: [web] Fix long names in displaying incorrectly in the ChatMessageListContainers…

Summary

issue: https://linear.app/comm/issue/ENG-3070/fix-long-names-displaying-incorrectly-in-the-chatmessagelistcontainers
Long names used to display incorrectly: the white space would wrap around, and long names with no spaces would go off the screen. this diff fixes that. note that since D6745 in this header we only show the chats name

Test Plan

Run web app, checked thatt long names display correctly in the ChatMessageListContainers header (and so do short names)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Feb 23 2023, 6:18 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 23 2023, 6:18 AM

inka edited the summary of this revision. (Show Details)Feb 23 2023, 6:19 AM

inka edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B16822: Diff 22997.Feb 23 2023, 6:33 AM

inka requested review of this revision.Feb 23 2023, 6:33 AM

bartek accepted this revision.Feb 24 2023, 5:54 AM

bartek added inline comments.

web/chat/thread-top-bar.css
23 ↗	(On Diff #22997)	Just curious - why is flex needed here?

This revision is now accepted and ready to land.Feb 24 2023, 5:54 AM

inka added inline comments.Feb 27 2023, 12:42 PM

web/chat/thread-top-bar.css
23 ↗	(On Diff #22997)	Otherwise the square gets squished:

inka attached a referenced file: F404023: image.png. (Show Details)Feb 27 2023, 12:42 PM

Closed by commit rCOMM5339cf4c28f1: [web] Fix long names in displaying incorrectly in the ChatMessageListContainers… (authored by • InkaSokolowska). · Explain WhyMar 13 2023, 6:35 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM5339cf4c28f1: [web] Fix long names in displaying incorrectly in the ChatMessageListContainers….

inka mentioned this in D6393: Fixed incorret display for long thread names on web..Mar 14 2023, 7:37 AM

Revision Contents
Changeset List

Path

Size

web/

chat/

thread-top-bar.css

7 lines

thread-top-bar.react.js

2 lines

Diff 23687

web/chat/thread-top-bar.css

Loading...

web/chat/thread-top-bar.react.js

Loading...