Page MenuHomePhabricator
Differential D6851

[web] Fix long names in displaying incorrectly in the ChatMessageListContainers header
ClosedPublic
Actions

Authored by inka on Feb 23 2023, 6:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 21, 5:59 PM
Unknown Object (File)
Sat, Oct 19, 10:23 AM
Unknown Object (File)
Fri, Oct 18, 5:12 AM
Unknown Object (File)
Fri, Oct 18, 5:12 AM
Unknown Object (File)
Thu, Oct 17, 8:08 AM
Unknown Object (File)
Thu, Oct 17, 8:08 AM
Unknown Object (File)
Thu, Oct 17, 8:06 AM
Unknown Object (File)
Thu, Oct 17, 7:54 AM
View All 98 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
• kuba
bartek
Commits
rCOMM5339cf4c28f1: [web] Fix long names in displaying incorrectly in the ChatMessageListContainers…
Summary

issue: https://linear.app/comm/issue/ENG-3070/fix-long-names-displaying-incorrectly-in-the-chatmessagelistcontainers
Long names used to display incorrectly: the white space would wrap around, and long names with no spaces would go off the screen. this diff fixes that. note that since D6745 in this header we only show the chats name

image.png (150×1 px, 20 KB)

image.png (204×1 px, 22 KB)

Test Plan

Run web app, checked thatt long names display correctly in the ChatMessageListContainers header (and so do short names)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Feb 23 2023, 6:18 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 23 2023, 6:18 AM
inka edited the summary of this revision. (Show Details)Feb 23 2023, 6:19 AM
inka edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B16822: Diff 22997.Feb 23 2023, 6:33 AM
inka requested review of this revision.Feb 23 2023, 6:33 AM
bartek accepted this revision.Feb 24 2023, 5:54 AM
bartek added inline comments.
web/chat/thread-top-bar.css
23 ↗(On Diff #22997)

Just curious - why is flex needed here?

This revision is now accepted and ready to land.Feb 24 2023, 5:54 AM
inka added inline comments.Feb 27 2023, 12:42 PM
web/chat/thread-top-bar.css
23 ↗(On Diff #22997)

Otherwise the square gets squished:

image.png (124×1 px, 24 KB)

inka attached a referenced file: F404023: image.png. (Show Details)Feb 27 2023, 12:42 PM
Closed by commit rCOMM5339cf4c28f1: [web] Fix long names in displaying incorrectly in the ChatMessageListContainers… (authored by • InkaSokolowska). · Explain WhyMar 13 2023, 6:35 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM5339cf4c28f1: [web] Fix long names in displaying incorrectly in the ChatMessageListContainers….
inka mentioned this in D6393: Fixed incorret display for long thread names on web..Mar 14 2023, 7:37 AM

Revision Contents
Changeset List

PathSize
web/
chat/
7 lines
2 lines

Diff 23687

View Options

web/chat/thread-top-bar.css

Loading...
View Options

web/chat/thread-top-bar.react.js

Loading...