Page MenuHomePhabricator
Differential D6777

Implement public method to initialize (generate and persist new) notifications olm account
ClosedPublic
Actions

Authored by marcin on Feb 20 2023, 4:55 AM.
Tags
None
Referenced Files
F1774049: D6777.diff
Thu, May 16, 12:25 AM
Unknown Object (File)
Sat, May 11, 5:21 AM
Unknown Object (File)
Sat, May 11, 5:21 AM
Unknown Object (File)
Sat, May 11, 12:03 AM
Unknown Object (File)
Sat, May 11, 12:03 AM
Unknown Object (File)
Sat, May 11, 12:03 AM
Unknown Object (File)
Sat, May 11, 12:02 AM
Unknown Object (File)
Sun, Apr 28, 9:06 AM
View All 84 Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
kamil
bartek
Commits
rCOMMd8311f860caf: Implement public method to initialize (generate and persist new) notifications…
Summary

This differential implements public method to initialize (generate if not exists and persist new) notifications olm account. Account generation follows the same semantics as public olm account generation in CommCoreModule. If the account already exists it will ne be re-created.
Atomic and fault-tolerant implementation of private serializeAndFlush method guarantees that if the file exists it is created correctly.

Test Plan

Call this method in CommCoreModule.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2901
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Feb 20 2023, 4:55 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptFeb 20 2023, 4:55 AM
marcin added a parent revision: D6776: Implement method in NotificationsCryptoModule to serialize CryptoModule instance and atomically store it in a file..Feb 20 2023, 4:56 AM
marcin added a child revision: D6778: Implement public method to retrieve notifications olm account public keys.Feb 20 2023, 5:06 AM
marcin published this revision for review.Feb 20 2023, 5:14 AM
Harbormaster failed remote builds in B16607: Diff 22713!Feb 20 2023, 7:41 AM
marcin updated this revision to Diff 22881.Feb 21 2023, 10:50 AM

Rebase

Harbormaster completed remote builds in B16726: Diff 22881.Feb 21 2023, 11:09 AM
bartek added a comment.Feb 22 2023, 12:56 AM

Atomic and fault-tolerant implementation of private serializeAndFlush method guarantees that if the file exists it is created correctly.

I'm probably too picky, but could it be replaced in the meantime by any 3rd party?
Besides that, LGTM ;)

marcin added a comment.EditedFeb 22 2023, 2:40 AM
In D6777#203015, @bartek wrote:

Atomic and fault-tolerant implementation of private serializeAndFlush method guarantees that if the file exists it is created correctly.

I'm probably too picky, but could it be replaced in the meantime by any 3rd party?

I am not sure what do you refer to here. Do you mean whether it is possible that 3rd party library will write to this file? Or 3rd party application?

bartek accepted this revision.Feb 23 2023, 12:24 AM

I am not sure what do you refer to here. Do you mean whether it is possible that 3rd party library will write to this file? Or 3rd party application?

Never mind, I meant some malicious code, but my concern is probably out of scope

This revision is now accepted and ready to land.Feb 23 2023, 12:24 AM
bartek mentioned this in D6775: Implement method to deserialize olm account from a file.Feb 23 2023, 12:28 AM
marcin updated this revision to Diff 23255.Feb 28 2023, 10:06 AM

Rebase before landing

Harbormaster failed remote builds in B17001: Diff 23255!Feb 28 2023, 10:20 AM
Harbormaster completed remote builds in B17001: Diff 23255.Feb 28 2023, 1:57 PM
marcin updated this revision to Diff 23309.Mar 1 2023, 1:21 AM

Rebase before landing

Harbormaster completed remote builds in B17026: Diff 23309.Mar 1 2023, 1:39 AM
Closed by commit rCOMMd8311f860caf: Implement public method to initialize (generate and persist new) notifications… (authored by marcin). · Explain WhyMar 1 2023, 2:04 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMd8311f860caf: Implement public method to initialize (generate and persist new) notifications….

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
Notifications/
BackgroundDataStorage/
29 lines

Diff 22713

View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp

Loading...