This differential removes userID argument from initializeCryptoAccount method in CommCoreModule since it it not used and is not necessary.
I understand that this differential covers a lot of files, but two of them are just effect of running yarn codegen-jsi and I think ot would be hard to split the rest without creating a differential that breaks CI or introduces changes that make app temporarily not working correctly.
Details
Details
Build the app. Ensure public keys are correctly created/retrieved in places where this method of CommCoreModule is called in JS.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-2901
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
FYI I think this might break the XCTest workflow on GitHub Actions. We might be able to rip out the failing tests if they're no longer relevant?
Comment Actions
FYI I think this might break the XCTest workflow on GitHub Actions. We might be able to rip out the failing tests if they're no longer relevant?
In this case, I suggest running these tests in Xcode and fix/remove them before landing this (Command + U)
However, after a brief look, they should still pass as CryptoModule constructor hasn't changed itself, but only its callsite
Comment Actions
I will run the test, but I am pretty positive nothing has been broken. Changes in this diff are exclusively related to CommCoreModule , not the CryptoModule which is the subject of the tests. id argument required for CryptoModule constructor is hardcoded in CommCoreModule.h and used instead of userID previously passed as an argumen.