Page MenuHomePhabricator
Differential D6784

[keyserver] Fix rust-node-addon after deprecation of --experimental-specifier-resolution=node
ClosedPublic
Actions

Authored by ashoat on Feb 20 2023, 9:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 10:40 AM
Unknown Object (File)
Sun, Oct 27, 5:51 PM
Unknown Object (File)
Mon, Oct 21, 10:30 AM
Unknown Object (File)
Mon, Oct 21, 10:30 AM
Unknown Object (File)
Sun, Oct 20, 1:21 AM
Unknown Object (File)
Fri, Oct 18, 3:24 AM
Unknown Object (File)
Fri, Oct 18, 3:24 AM
Unknown Object (File)
Fri, Oct 18, 3:24 AM
View All Files
Subscribers
atul
• jon
tomek

Details

Reviewers
• jon
varun
• max
Commits
rCOMM9acb9c0e57f2: [keyserver] Fix rust-node-addon after deprecation of --experimental-specifier…
Summary

Context in ENG-3059. rust-node-addon was broken by D6695, but --experimental-specifier-resolution=node is going away so we need another solution.

I got this solution from this GitHub comment.

Depends on D6783

Test Plan

Confirm I could import rust-node-addon and call methods on it from @jon's jonringer/identity-deleteuserrpc branch

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Feb 20 2023, 9:57 AM
Herald added subscribers: atul, tomek. · View Herald TranscriptFeb 20 2023, 9:57 AM
ashoat added a reviewer: • max.Feb 20 2023, 9:58 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 20 2023, 10:08 AM
Harbormaster failed remote builds in B16624: Diff 22731!
ashoat updated this revision to Diff 22734.Feb 20 2023, 11:03 AM

Flow had an error because it thinks import.meta.url might not be set, so I added an invariant to make sure it is always set

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 20 2023, 11:06 AM
Harbormaster failed remote builds in B16626: Diff 22734!
ashoat requested review of this revision.Feb 20 2023, 11:24 AM
ashoat updated this revision to Diff 22739.Feb 20 2023, 11:47 AM

Rebase on D6785 to fix iOS CI build

• jon accepted this revision.Feb 20 2023, 12:15 PM

Forced call to getRustAPI() on master, asserted it was broken, patch this in, and fixed the call.

This revision is now accepted and ready to land.Feb 20 2023, 12:15 PM
Harbormaster completed remote builds in B16631: Diff 22739.Feb 20 2023, 12:18 PM
Closed by commit rCOMM9acb9c0e57f2: [keyserver] Fix rust-node-addon after deprecation of --experimental-specifier… (authored by ashoat). · Explain WhyFeb 20 2023, 12:25 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM9acb9c0e57f2: [keyserver] Fix rust-node-addon after deprecation of --experimental-specifier….
ashoat mentioned this in D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.Feb 20 2023, 2:41 PM

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
17 lines
3 lines

Diff 22739

View Options

keyserver/addons/rust-node-addon/index.js

Loading...
View Options

keyserver/addons/rust-node-addon/package.json

Loading...