Page MenuHomePhabricator
Differential D6918

Silence rescinds in NSE
ClosedPublic
Actions

Authored by marcin on Mar 1 2023, 3:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 3:39 AM
Unknown Object (File)
Fri, Apr 12, 3:39 AM
Unknown Object (File)
Fri, Apr 12, 3:38 AM
Unknown Object (File)
Fri, Apr 12, 3:38 AM
Unknown Object (File)
Fri, Apr 12, 3:38 AM
Unknown Object (File)
Fri, Apr 12, 3:35 AM
Unknown Object (File)
Feb 26 2024, 4:52 PM
Unknown Object (File)
Feb 23 2024, 8:39 AM
View All 54 Files
Subscribers
ashoat

Details

Reviewers
bartek
atul
tomek
kamil
Commits
rCOMM70905d6a8d4d: Silence rescinds in NSE
Summary

This differential implements code to silence rescinds so that they are not visible to users. No actual rescind processing is done.

Test Plan

Remove codeVersion > 1000 from send.js and rescind.js files in keyserver in prepareIOSNotification functions. Generate rescind. Ensure it is not displayed to the user. This is how we use notifications filtering capability:
https://developer.apple.com/documentation/bundleresources/entitlements/com_apple_developer_usernotifications_filtering?language=objc

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Mar 1 2023, 3:47 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 1 2023, 3:47 AM
marcin added a parent revision: D6917: Prepare to conditionally process rescinds in NSE..Mar 1 2023, 3:48 AM
marcin added a child revision: D6919: Remove relevant notification from notifications center when receiving rescind in NSE.Mar 1 2023, 3:56 AM
Harbormaster completed remote builds in B17035: Diff 23330.Mar 1 2023, 4:02 AM
marcin requested review of this revision.Mar 1 2023, 4:02 AM
marcin updated this revision to Diff 23337.Mar 1 2023, 5:37 AM

Add constant for rescind type indicator

Harbormaster completed remote builds in B17042: Diff 23337.Mar 1 2023, 5:51 AM
atul accepted this revision.Mar 6 2023, 11:41 AM

Looks reasonable to me. Might be good to add someone with more context on notifications as blocking?

This revision is now accepted and ready to land.Mar 6 2023, 11:41 AM
bartek accepted this revision.Mar 8 2023, 1:21 AM
marcin updated this revision to Diff 23755.Mar 15 2023, 7:08 AM

Rebase before landing

Harbormaster completed remote builds in B17344: Diff 23755.Mar 15 2023, 7:24 AM
Closed by commit rCOMM70905d6a8d4d: Silence rescinds in NSE (authored by marcin). · Explain WhyMar 15 2023, 7:45 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM70905d6a8d4d: Silence rescinds in NSE.

Revision Contents
Changeset List

PathSize
native/
ios/
NotificationService/
22 lines

Diff 23762

View Options

native/ios/NotificationService/NotificationService.mm

Loading...