This differential implements code to silence rescinds so that they are not visible to users. No actual rescind processing is done.
Details
Details
- Reviewers
bartek atul tomek kamil - Commits
- rCOMM70905d6a8d4d: Silence rescinds in NSE
Remove codeVersion > 1000 from send.js and rescind.js files in keyserver in prepareIOSNotification functions. Generate rescind. Ensure it is not displayed to the user. This is how we use notifications filtering capability:
https://developer.apple.com/documentation/bundleresources/entitlements/com_apple_developer_usernotifications_filtering?language=objc
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks reasonable to me. Might be good to add someone with more context on notifications as blocking?