Page MenuHomePhabricator
Differential D6932

[keyserver] Only set sidebarCreation flag for the first message in the sidebar
ClosedPublic
Actions

Authored by ashoat on Mar 2 2023, 2:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 11:01 AM
Unknown Object (File)
Sun, Apr 6, 11:01 AM
Unknown Object (File)
Sun, Apr 6, 11:01 AM
Unknown Object (File)
Sun, Apr 6, 11:00 AM
Unknown Object (File)
Thu, Apr 3, 7:28 AM
Unknown Object (File)
Thu, Apr 3, 7:28 AM
Unknown Object (File)
Thu, Apr 3, 7:28 AM
Unknown Object (File)
Thu, Apr 3, 7:28 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMM6c3bc221b254: [keyserver] Only set sidebarCreation flag for the first message in the sidebar
Summary

When I say "first message" in the commit title, I really mean the third message, as each sidebar starts with a SIDEBAR_SOURCE and then a CREATE_SIDEBAR.

Check out the code comment for an explanation as to why we're doing this.

Test Plan

Force sidebarCreation to true on the client for all text messages, and confirm that it is ignored when invalid

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
11 lines
responders/
12 lines

Diff 23413

View Options

keyserver/src/fetchers/message-fetchers.js

Show First 20 Lines • Show All 166 Lines • ▼ Show 20 Lines default_action {
type = "forward" type = "forward"
forward { forward {
# ECS target group # ECS target group
target_group { target_group {
arn = aws_lb_target_group.identity_service_grpc.arn arn = aws_lb_target_group.identity_service_grpc.arn
weight = 1 weight = 1
} }
# Legacy EC2 Target # Legacy EC2 Target
target_group { dynamic "target_group" {
arn = data.aws_lb_target_group.identity_service_legacy_ec2.arn for_each = data.aws_lb_target_group.identity_service_legacy_ec2
content {
arn = target_group.value["arn"]
weight = 0 weight = 0
} }
} }
} }
}
lifecycle { lifecycle {
# Required only for existing resources to avoid plan difference # Required only for existing resources to avoid plan difference
ignore_changes = [default_action[0].forward[0].stickiness[0].duration] ignore_changes = [default_action[0].forward[0].stickiness[0].duration]
# Target group cannot be destroyed if it is used # Target group cannot be destroyed if it is used
replace_triggered_by = [aws_lb_target_group.identity_service_grpc] replace_triggered_by = [aws_lb_target_group.identity_service_grpc]
} }
} }
# SSL Certificate # SSL Certificate
data "aws_acm_certificate" "identity_service" { data "aws_acm_certificate" "identity_service" {
domain = "identity.commtechnologies.org" domain = "identity.commtechnologies.org"
statuses = ["ISSUED"] statuses = ["ISSUED"]
} }
# Legacy EC2 instance target # Legacy EC2 instance target
data "aws_lb_target_group" "identity_service_legacy_ec2" { data "aws_lb_target_group" "identity_service_legacy_ec2" {
# We don't have legacy EC2 services in staging
count = local.is_staging ? 0 : 1
name = "identity-service-tg" name = "identity-service-tg"
} }
# Required for Route53 DNS record # Required for Route53 DNS record
output "identity_service_load_balancer_dns_name" { output "identity_service_load_balancer_dns_name" {
value = aws_lb.identity_service.dns_name value = aws_lb.identity_service.dns_name
} }
View Options

keyserver/src/responders/message-responders.js

Show First 20 Lines • Show All 166 Lines • ▼ Show 20 Lines default_action {
type = "forward" type = "forward"
forward { forward {
# ECS target group # ECS target group
target_group { target_group {
arn = aws_lb_target_group.identity_service_grpc.arn arn = aws_lb_target_group.identity_service_grpc.arn
weight = 1 weight = 1
} }
# Legacy EC2 Target # Legacy EC2 Target
target_group { dynamic "target_group" {
arn = data.aws_lb_target_group.identity_service_legacy_ec2.arn for_each = data.aws_lb_target_group.identity_service_legacy_ec2
content {
arn = target_group.value["arn"]
weight = 0 weight = 0
} }
} }
} }
}
lifecycle { lifecycle {
# Required only for existing resources to avoid plan difference # Required only for existing resources to avoid plan difference
ignore_changes = [default_action[0].forward[0].stickiness[0].duration] ignore_changes = [default_action[0].forward[0].stickiness[0].duration]
# Target group cannot be destroyed if it is used # Target group cannot be destroyed if it is used
replace_triggered_by = [aws_lb_target_group.identity_service_grpc] replace_triggered_by = [aws_lb_target_group.identity_service_grpc]
} }
} }
# SSL Certificate # SSL Certificate
data "aws_acm_certificate" "identity_service" { data "aws_acm_certificate" "identity_service" {
domain = "identity.commtechnologies.org" domain = "identity.commtechnologies.org"
statuses = ["ISSUED"] statuses = ["ISSUED"]
} }
# Legacy EC2 instance target # Legacy EC2 instance target
data "aws_lb_target_group" "identity_service_legacy_ec2" { data "aws_lb_target_group" "identity_service_legacy_ec2" {
# We don't have legacy EC2 services in staging
count = local.is_staging ? 0 : 1
name = "identity-service-tg" name = "identity-service-tg"
} }
# Required for Route53 DNS record # Required for Route53 DNS record
output "identity_service_load_balancer_dns_name" { output "identity_service_load_balancer_dns_name" {
value = aws_lb.identity_service.dns_name value = aws_lb.identity_service.dns_name
} }