Paths

Table of Contentst

-
lib/shared/
-
shared/
-
messages/
-
create-sidebar-message-spec.js
-
notif-utils.js

Differential D6937

[lib] Extract notifTextsForSidebarCreation
ClosedPublic
Actions

Authored by ashoat on Mar 2 2023, 2:05 PM.

Details

Reviewers

atul

Commits

rCOMM0e3776a47f81: [lib] Extract notifTextsForSidebarCreation

Summary

In a later diff, we'll introduce a new callsite for this from text-message-spec.js.

Depends on D6936

Test Plan

Flow, and tested in combination with the next diffs to confirm that getting @-tagged in a message that triggers the creation of a sidebar will update the SIDEBAR_CREATION notif
to be suffixed with "and tagged you"

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 2 2023, 2:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 2 2023, 2:05 PM

ashoat added a child revision: D6938: [lib] Include fact that you were tagged in sidebar creation message.Mar 2 2023, 2:05 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2023, 2:20 PM

Harbormaster failed remote builds in B17071: Diff 23373!

Rebase

Harbormaster completed remote builds in B17077: Diff 23381.Mar 2 2023, 3:52 PM

ashoat requested review of this revision.Mar 2 2023, 3:52 PM

atul accepted this revision.Mar 3 2023, 11:25 AM

This revision is now accepted and ready to land.Mar 3 2023, 11:25 AM

Closed by commit rCOMM0e3776a47f81: [lib] Extract notifTextsForSidebarCreation (authored by ashoat). · Explain WhyMar 3 2023, 12:11 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM0e3776a47f81: [lib] Extract notifTextsForSidebarCreation.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

create-sidebar-message-spec.js

44 lines

notif-utils.js

54 lines

Diff 23418

View Options

lib/shared/messages/create-sidebar-message-spec.js