Page MenuHomePhabricator

[keyserver] Dedup notifTextsForMessageInfo calls in sendPushNotifs
ClosedPublic

Authored by ashoat on Mar 2 2023, 2:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 3:11 PM
Unknown Object (File)
Sat, Oct 19, 5:02 PM
Unknown Object (File)
Fri, Oct 18, 9:51 AM
Unknown Object (File)
Fri, Oct 18, 9:50 AM
Unknown Object (File)
Fri, Oct 18, 9:50 AM
Unknown Object (File)
Fri, Oct 18, 9:50 AM
Unknown Object (File)
Sep 27 2024, 9:26 PM
Unknown Object (File)
Sep 27 2024, 9:26 PM
Subscribers

Details

Summary

We don't need to call this separately for each platform... the result is the same each time.

Test Plan

Flow, and tested in combination with the next diffs to confirm that getting @-tagged in a message that triggers the creation of a sidebar will update the SIDEBAR_CREATION notif to be suffixed with "and tagged you"

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2023, 2:19 PM
Harbormaster failed remote builds in B17069: Diff 23371!

Fix Prettier error that I caused while resolving merge conflicts

ashoat requested review of this revision.Mar 2 2023, 3:51 PM
This revision is now accepted and ready to land.Mar 3 2023, 11:01 AM