Page MenuHomePhabricator
Differential D6935

[keyserver] Dedup notifTextsForMessageInfo calls in sendPushNotifs
ClosedPublic
Actions

Authored by ashoat on Mar 2 2023, 2:04 PM.
Tags
None
Referenced Files
F2830817: D6935.id23417.diff
Fri, Sep 27, 9:26 PM
F2830816: D6935.id23379.diff
Fri, Sep 27, 9:26 PM
F2830815: D6935.id23371.diff
Fri, Sep 27, 9:26 PM
F2830795: D6935.id.diff
Fri, Sep 27, 9:25 PM
F2830772: D6935.diff
Fri, Sep 27, 9:20 PM
Unknown Object (File)
Sat, Sep 21, 12:51 AM
Unknown Object (File)
Fri, Sep 20, 7:31 PM
Unknown Object (File)
Tue, Sep 17, 10:04 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMMf54f9346616e: [keyserver] Dedup notifTextsForMessageInfo calls in sendPushNotifs
Summary

We don't need to call this separately for each platform... the result is the same each time.

Test Plan

Flow, and tested in combination with the next diffs to confirm that getting @-tagged in a message that triggers the creation of a sidebar will update the SIDEBAR_CREATION notif to be suffixed with "and tagged you"

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mar 2 2023, 2:04 PM
Herald added a subscriber: tomek. · View Herald TranscriptMar 2 2023, 2:04 PM
ashoat added a parent revision: D6934: [keyserver] Drill MessageDatas into notificationCollapseKey.Mar 2 2023, 2:04 PM
ashoat added a child revision: D6936: [keyserver][lib] Allow notificationTexts to return null.Mar 2 2023, 2:05 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2023, 2:19 PM
Harbormaster failed remote builds in B17069: Diff 23371!
ashoat updated this revision to Diff 23379.Mar 2 2023, 3:35 PM

Fix Prettier error that I caused while resolving merge conflicts

Harbormaster completed remote builds in B17075: Diff 23379.Mar 2 2023, 3:51 PM
ashoat requested review of this revision.Mar 2 2023, 3:51 PM
atul accepted this revision.Mar 3 2023, 11:01 AM
This revision is now accepted and ready to land.Mar 3 2023, 11:01 AM
Closed by commit rCOMMf54f9346616e: [keyserver] Dedup notifTextsForMessageInfo calls in sendPushNotifs (authored by ashoat). · Explain WhyMar 3 2023, 12:11 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMf54f9346616e: [keyserver] Dedup notifTextsForMessageInfo calls in sendPushNotifs.
ashoat mentioned this in D9007: [keyserver] Render chat mention in notification text.Sep 11 2023, 1:45 PM
ashoat mentioned this in D9175: [keyserver] Extract sendPushNotif.Sep 12 2023, 6:15 PM
ashoat mentioned this in rCOMMd44f1223581a: [keyserver] Extract sendPushNotif.Sep 13 2023, 10:14 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
101 lines

Diff 23379

View Options

keyserver/src/push/send.js

Loading...