Paths

Table of Contentst

Differential D6936

[keyserver][lib] Allow notificationTexts to return null
ClosedPublic
Actions

Authored by ashoat on Mar 2 2023, 2:05 PM.

Tags

None

Referenced Files

	F2113502: D6936.id.diff
	Wed, Jun 26, 3:53 AM

	F2113447: D6936.diff
	Wed, Jun 26, 3:46 AM

	Unknown Object (File)
	Mon, Jun 24, 2:50 AM

	Unknown Object (File)
	Tue, Jun 11, 5:31 PM

	Unknown Object (File)
	Thu, May 30, 4:10 AM

	Unknown Object (File)
	Thu, May 30, 4:10 AM

	Unknown Object (File)
	Thu, May 30, 4:10 AM

	Unknown Object (File)
	May 26 2024, 9:06 AM

View All 67 Files

Subscribers

Details

Reviewers

Commits

rCOMMcd53fa783f4a: [keyserver][lib] Allow notificationTexts to return null

Summary

In order to decide whether to send a notif, we may need more information than we have at the time generatesNotifs is called.

More concretely: in a later diff, we'll need to make a decision on whether to send a notif based on the contents of an earlier message with the same collapse key.

Depends on D6935

Test Plan

Flow, and tested in combination with the next diffs to confirm that getting @-tagged in a message that triggers the creation of a sidebar will update the SIDEBAR_CREATION notif
to be suffixed with "and tagged you"

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 2 2023, 2:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 2 2023, 2:05 PM

ashoat added a child revision: D6937: [lib] Extract notifTextsForSidebarCreation.Mar 2 2023, 2:05 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2023, 2:19 PM

Harbormaster failed remote builds in B17070: Diff 23372!

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2023, 3:45 PM

Harbormaster failed remote builds in B17076: Diff 23380!

Harbormaster completed remote builds in B17076: Diff 23380.Mar 2 2023, 3:51 PM

ashoat requested review of this revision.Mar 2 2023, 3:51 PM

atul accepted this revision.Mar 3 2023, 11:01 AM

This revision is now accepted and ready to land.Mar 3 2023, 11:01 AM

Closed by commit rCOMMcd53fa783f4a: [keyserver][lib] Allow notificationTexts to return null (authored by ashoat). · Explain WhyMar 3 2023, 12:11 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMcd53fa783f4a: [keyserver][lib] Allow notificationTexts to return null.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

3 lines

lib/

shared/

messages/

message-spec.js

4 lines

10 lines

Diff 23416

keyserver/src/push/send.js

Loading...

lib/shared/messages/message-spec.js

Loading...

lib/shared/notif-utils.js

Loading...