[keyserver] Drill MessageDatas into sendPushNotifs
ClosedPublic
Actions

Authored by ashoat on Mar 2 2023, 2:03 PM.

Details

Reviewers

atul

Commits

rCOMM7e9c849bb41e: [keyserver] Drill MessageDatas into sendPushNotifs

Summary

In the next diff, we'll pass the MessageDatas into notificationCollapseKey on the message specs.

Depends on D6932

Test Plan

Flow, and tested in combination with the next diffs to confirm that getting @-tagged in a message that triggers the creation of a sidebar will update the SIDEBAR_CREATION notif to be suffixed with "and tagged you"

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 2 2023, 2:03 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 2 2023, 2:03 PM

ashoat added a child revision: D6934: [keyserver] Drill MessageDatas into notificationCollapseKey.Mar 2 2023, 2:03 PM

Harbormaster completed remote builds in B17067: Diff 23369.Mar 2 2023, 2:18 PM

ashoat requested review of this revision.Mar 2 2023, 2:18 PM

atul accepted this revision.Mar 3 2023, 10:57 AM

This revision is now accepted and ready to land.Mar 3 2023, 10:57 AM

Closed by commit rCOMM7e9c849bb41e: [keyserver] Drill MessageDatas into sendPushNotifs (authored by ashoat). · Explain WhyMar 3 2023, 12:11 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM7e9c849bb41e: [keyserver] Drill MessageDatas into sendPushNotifs.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

message-creator.js

17 lines

push/

send.js

3 lines

Diff 23414

View Options

keyserver/src/creators/message-creator.js