Page MenuHomePhabricator

[identity] db and siwe verification changes to handle login requests from keyserver
ClosedPublic

Authored by varun on Mar 3 2023, 12:48 AM.
Tags
None
Referenced Files
F1656720: D6945.diff
Wed, Apr 24, 2:27 PM
Unknown Object (File)
Sun, Apr 7, 11:26 PM
Unknown Object (File)
Wed, Apr 3, 9:18 PM
Unknown Object (File)
Thu, Mar 28, 7:25 PM
Unknown Object (File)
Feb 27 2024, 11:49 PM
Unknown Object (File)
Feb 27 2024, 11:49 PM
Unknown Object (File)
Feb 27 2024, 11:48 PM
Unknown Object (File)
Feb 27 2024, 11:42 PM
Subscribers

Details

Summary

DB changes: If a given user does not already exist, we change the way we construct the update expression to avoid a validation exception from DynamoDB

SIWE changes: The signature from keyserver is hex encoded, so we decode it to a Vec<u8>

Depends on D6943

Test Plan

called the update_users_table method from the loginUserPake and loginUserWallet functions in the keyserver,
both succeeded

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun requested review of this revision.Mar 3 2023, 1:03 AM

otherwise looks fine rust wise

services/identity/src/service.rs
355–370 ↗(On Diff #23394)

since you call ?, we should just get back the signature, this doesnt work?

This revision is now accepted and ready to land.Mar 3 2023, 12:50 PM
services/identity/src/service.rs
355–370 ↗(On Diff #23394)

the verify method takes a slice of exactly 65 bytes, so we still need the try_into()