Page MenuHomePhabricator
Differential D6978

[web] Add a badge on the Inbox button
ClosedPublic
Actions

Authored by inka on Mar 7 2023, 4:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 3:19 AM
Unknown Object (File)
Fri, Apr 5, 9:04 PM
Unknown Object (File)
Thu, Apr 4, 10:11 PM
Unknown Object (File)
Thu, Apr 4, 10:11 PM
Unknown Object (File)
Thu, Apr 4, 10:10 PM
Unknown Object (File)
Thu, Apr 4, 10:10 PM
Unknown Object (File)
Thu, Apr 4, 10:10 PM
Unknown Object (File)
Thu, Apr 4, 10:09 PM
View All 80 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
• kuba
Commits
rCOMM65ad778124ed: [web] Add a badge on the Inbox button
Summary

issue: https://linear.app/comm/issue/ENG-3178/add-a-badge-on-the-inbox-all-communities-button
This code is effectively copied from app-switcher.react.js, where the badge exacly like what we want here already exists (that badge will be changed)

Screenshot 2023-03-07 at 17.00.36.png (504×1 px, 58 KB)

Screenshot 2023-03-07 at 17.00.23.png (512×1 px, 53 KB)

Test Plan

rub web app, checked that the badge is visible in all tabs but the Calendar tab, and displays the correct number of unreads

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Mar 7 2023, 4:35 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 7 2023, 4:35 AM
inka edited the summary of this revision. (Show Details)Mar 7 2023, 4:36 AM
inka attached a referenced file: F415722: Screenshot 2023-03-07 at 13.31.11.png. (Show Details)
Harbormaster completed remote builds in B17151: Diff 23491.Mar 7 2023, 4:51 AM
inka requested review of this revision.Mar 7 2023, 4:51 AM
inka added a child revision: D6979: [web] Add a selector for getting the number of unnreads in the selected community.Mar 7 2023, 4:54 AM
inka updated this revision to Diff 23502.Mar 7 2023, 8:02 AM

Make over 100 notifs display as 99+

inka edited the summary of this revision. (Show Details)Mar 7 2023, 8:02 AM
Harbormaster completed remote builds in B17161: Diff 23502.Mar 7 2023, 8:18 AM
inka attached a referenced file: F415968: Screenshot 2023-03-07 at 17.00.23.png. (Show Details)Mar 23 2023, 3:54 AM
inka attached a referenced file: F415969: Screenshot 2023-03-07 at 17.00.36.png. (Show Details)
ashoat added a comment.Mar 23 2023, 12:30 PM

On context on why this diff has been up for 2 weeks and hasn't been reviewed?

The expectation on this team is that all diffs are reviewed within 24 hours. Review queues should be cleared on a daily basis. If the diff is not ready for review, it should be marked with "Plan Changes". Otherwise, the reviewers are expected to review it within 24 hours.

inka updated this revision to Diff 24774.Apr 7 2023, 6:28 AM

Rebase above message editing

Harbormaster completed remote builds in B18074: Diff 24774.Apr 7 2023, 6:45 AM
michal accepted this revision.Apr 12 2023, 5:25 AM

Looks good!

Sorry for not reviewing it for so long, it won't happen again!

This revision is now accepted and ready to land.Apr 12 2023, 5:25 AM
inka updated this revision to Diff 26769.May 22 2023, 6:00 AM

Rebase

Harbormaster completed remote builds in B19584: Diff 26769.May 22 2023, 6:18 AM
Closed by commit rCOMM65ad778124ed: [web] Add a badge on the Inbox button (authored by • InkaSokolowska). · Explain WhyMay 23 2023, 1:01 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM65ad778124ed: [web] Add a badge on the Inbox button.

Revision Contents
Changeset List

PathSize
web/
sidebar/
19 lines
14 lines

Diff 26833

View Options

web/sidebar/community-picker.css

Loading...
View Options

web/sidebar/community-picker.react.js

Loading...