Page MenuHomePhabricator
Differential D6979

[web] Add a selector for getting the number of unnreads in the selected community
ClosedPublic
Actions

Authored by inka on Mar 7 2023, 4:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 7:44 AM
Unknown Object (File)
Tue, Nov 19, 7:44 AM
Unknown Object (File)
Tue, Nov 19, 7:44 AM
Unknown Object (File)
Tue, Nov 19, 7:44 AM
Unknown Object (File)
Tue, Nov 19, 7:44 AM
Unknown Object (File)
Tue, Nov 19, 7:39 AM
Unknown Object (File)
Tue, Nov 19, 7:34 AM
Unknown Object (File)
Sat, Nov 2, 2:28 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
• kuba
Commits
rCOMM303fafe8b2b2: [web] Add a selector for getting the number of unnreads in the selected…
Summary

issue: https://linear.app/comm/issue/ENG-3179/make-the-badge-on-the-chat-tab-responsive-to-drawer-selection
We want the badge on the chat tab to display the number of unreads for the selected community.
This selector is almost identical to unreadCount selector that was used here before, for getting the number of all unreads, it only adds the (!communityID || communityID === threadInfo.community) condition

when we navigate to Calendar the number on the Chat tab is still supposed to display the number for the community selected in the Chat tab

Test Plan

run web app, checked that the number on the badge takes into account only chats from the current community

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Mar 7 2023, 4:54 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 7 2023, 4:54 AM
inka added a parent revision: D6978: [web] Add a badge on the Inbox button.Mar 7 2023, 4:54 AM
inka edited the summary of this revision. (Show Details)
inka attached a referenced file: F415748: Screen Recording 2023-03-07 at 13.45.45.mov. (Show Details)
Harbormaster completed remote builds in B17152: Diff 23492.Mar 7 2023, 5:09 AM
inka requested review of this revision.Mar 7 2023, 5:09 AM
inka updated this revision to Diff 24776.Apr 7 2023, 6:29 AM

Rebase above message editing

Harbormaster failed remote builds in B18076: Diff 24776!Apr 7 2023, 6:44 AM
inka updated this revision to Diff 24793.Apr 7 2023, 7:08 AM

Rebase

Harbormaster completed remote builds in B18093: Diff 24793.Apr 7 2023, 7:36 AM
michal accepted this revision.Apr 12 2023, 5:26 AM
michal added inline comments.
web/selectors/thread-selectors.js
133 ↗(On Diff #24793)

Do you think it would make sense to put it in lib, near unreadCount?

This revision is now accepted and ready to land.Apr 12 2023, 5:26 AM
inka added inline comments.Apr 12 2023, 5:37 AM
web/selectors/thread-selectors.js
133 ↗(On Diff #24793)

communityPickerStore this is based on is only in webs state, so I cannot put it in lib

A more high-level explanation is that we only "select a community" on web. We have no such behaviour on native, because the UI is different and it would be difficult to have it make sense to the user. So a selector that selects the number of unreads in a selected community doesn't make sense there.

michal added inline comments.Apr 12 2023, 5:40 AM
web/selectors/thread-selectors.js
133 ↗(On Diff #24793)

That makes sense, thanks for explaining!

inka updated this revision to Diff 26770.May 22 2023, 6:03 AM

Rebase

Harbormaster completed remote builds in B19585: Diff 26770.May 22 2023, 6:21 AM
Closed by commit rCOMM303fafe8b2b2: [web] Add a selector for getting the number of unnreads in the selected… (authored by • InkaSokolowska). · Explain WhyMay 23 2023, 1:01 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM303fafe8b2b2: [web] Add a selector for getting the number of unnreads in the selected….

Revision Contents
Changeset List

PathSize
web/
navigation-panels/
8 lines
selectors/
27 lines

Diff 26834

View Options

web/navigation-panels/app-switcher.react.js

Loading...
View Options

web/selectors/thread-selectors.js

Loading...