Differential D7023

[web] Add Flow types for WebCrypto / SubtleCrypto
AbandonedPublic
Actions

Authored by bartek on Thu, Mar 9, 10:10 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 25, 11:37 AM

	Unknown Object (File)
	Fri, Mar 24, 10:52 AM

	Unknown Object (File)
	Mon, Mar 20, 9:48 PM

	Unknown Object (File)
	Tue, Mar 14, 2:10 AM

	Unknown Object (File)
	Sat, Mar 11, 2:16 PM

	Unknown Object (File)
	Sat, Mar 11, 7:54 AM

Subscribers

Details

Reviewers

ashoat
inka
kamil
michal

Summary

The WebCrypto APIs are missing in Flow - see this GH issue: https://github.com/facebook/flow/issues/5019
There was a PR adding them but it was closed: https://github.com/facebook/flow/pull/7714

I copied the code from that PR and slightly modified it by removing TODO types
that were breaking type checks on valid code. Also made small adjustments for this
to fit types described on MDN: https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto

Test Plan

Flow doesn't complain. Tested this along with my code adding AES encryption.

Diff Detail

Repository

Branch

barthap/aes-web

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Thu, Mar 9, 10:10 AM

Herald added subscribers: atul, tomek. · View Herald TranscriptThu, Mar 9, 10:10 AM

Harbormaster completed remote builds in B17215: Diff 23579.Thu, Mar 9, 10:27 AM

bartek requested review of this revision.Thu, Mar 9, 10:27 AM

bartek added a child revision: D7024: [web] Implement AES encryption functions.Thu, Mar 9, 11:05 AM

Oops, This is a duplicate of D6994 - I'll sync with @kamil and we'll decide what to do

(To your queue and off my mine while you figure things out with @kamil)

This revision now requires changes to proceed.Thu, Mar 9, 11:46 AM

kamil mentioned this in D6994: [web-db] implement types for `SubtleCrypto` module.Fri, Mar 10, 7:11 AM

Replaced by D6994

Revision Contents
Changeset List

Path

Size

web/

flow-typed/

109 lines

utils/

5 lines

Diff 23579

web/flow-typed/WebCrypto.js

Loading...

web/utils/text-utils.js

Loading...