Paths

Table of Contentst

Differential D6994

[web-db] implement types for `SubtleCrypto` module
ClosedPublic
Actions

Authored by kamil on Tue, Mar 7, 9:31 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 8, 4:25 PM

	Unknown Object (File)
	Wed, Mar 8, 4:25 PM

	Unknown Object (File)
	Wed, Mar 8, 11:55 AM

Subscribers

Details

Reviewers

michal
tomek
bartek
ashoat

Commits

rCOMM498483793f2e: [web-db] implement types for `SubtleCrypto` module

Summary

There are no build in flow types for SubtleCrypto or any implementation we can use.

Adding types based on API docs and typescript.

Test Plan

N/A

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Tue, Mar 7, 9:31 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptTue, Mar 7, 9:31 AM

kamil added a child revision: D6995: [web-db] implement crypto functions.Tue, Mar 7, 9:35 AM

Harbormaster completed remote builds in B17170: Diff 23512.Tue, Mar 7, 9:47 AM

kamil published this revision for review.Tue, Mar 7, 10:08 AM

ashoat added inline comments.Tue, Mar 7, 4:32 PM

web/database/utils/crypto-types.js
138–263 ↗	(On Diff #23512)	Why aren't these ones read-only?
268–269 ↗	(On Diff #23512)	Why aren't these ones read-only?

michal added inline comments.Wed, Mar 8, 4:49 AM

web/database/utils/crypto-types.js
4 ↗	(On Diff #23512)	Can this be read-only?

bartek mentioned this in D7023: [web] Add Flow types for WebCrypto / SubtleCrypto.Thu, Mar 9, 11:39 AM

improve types and move to flow-typed

Previous types were too general (string instead of current algorithm names). I've updated this to be more precise (like D7023) but with specific types for the entire module - not only AES algorithms.

Checked if it works with D7024 (cc. @bartek).

Harbormaster completed remote builds in B17231: Diff 23601.Fri, Mar 10, 7:20 AM

ashoat accepted this revision.Fri, Mar 10, 10:51 AM

LGTM, Works with my changes. Thank you for taking care of this!

This revision is now accepted and ready to land.Sun, Mar 12, 11:48 PM

bartek added a child revision: D7024: [web] Implement AES encryption functions.Sun, Mar 12, 11:49 PM

Closed by commit rCOMM498483793f2e: [web-db] implement types for `SubtleCrypto` module (authored by kamil). · Explain WhyMon, Mar 13, 1:13 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM498483793f2e: [web-db] implement types for `SubtleCrypto` module.

Revision Contents
Changeset List

Path

Size

web/

flow-typed/

285 lines

utils/

5 lines

Diff 23664

web/flow-typed/WebCrypto.js

Loading...

web/utils/text-utils.js

Loading...