[web] Add unit tests for AES functions
ClosedPublic
Actions

Authored by bartek on Mar 9 2023, 11:23 AM.

Details

Reviewers

marcin
atul
inka
kamil

Commits

rCOMM5a9b3ee3b8c3: [web] Add unit tests for AES functions

Summary

Added unit tests for functions implemented in D7024

Depends on D7024
Depends on D7019

Test Plan

Ran these tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mar 9 2023, 11:23 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 9 2023, 11:23 AM

Harbormaster completed remote builds in B17222: Diff 23588.Mar 9 2023, 11:47 AM

bartek published this revision for review.Mar 9 2023, 11:11 PM

I'll add a test for the correct key, but the malformed ciphertext

Rebase
Added new tests

Harbormaster completed remote builds in B17287: Diff 23676.Mar 13 2023, 5:34 AM

Thanks for including these tests!

web/media/aes-crypto-utils.test.js
61–63 ↗	(On Diff #23676)	Appreciate the comments explaining what you're doing with the bitwise operators

This revision is now accepted and ready to land.Mar 13 2023, 4:45 PM

Rebase before landing

Harbormaster completed remote builds in B17404: Diff 23846.Mar 20 2023, 7:17 AM

Closed by commit rCOMM5a9b3ee3b8c3: [web] Add unit tests for AES functions (authored by bartek). · Explain WhyMar 20 2023, 7:30 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM5a9b3ee3b8c3: [web] Add unit tests for AES functions.

Revision Contents
Changeset List

Path

Size

web/

media/

aes-crypto-utils.test.js

88 lines

Diff 23862

View Options

web/media/aes-crypto-utils.test.js

[web] Add unit tests for AES functionsClosedPublicActions