Page MenuHomePhabricator

[web] Add unit tests for AES functions
ClosedPublic

Authored by bartek on Mar 9 2023, 11:23 AM.
Tags
None
Referenced Files
F1687753: D7025.id.diff
Wed, May 1, 6:51 AM
F1686784: D7025.id23676.diff
Tue, Apr 30, 10:58 PM
F1685883: D7025.diff
Tue, Apr 30, 6:45 PM
Unknown Object (File)
Sun, Apr 28, 4:32 PM
Unknown Object (File)
Fri, Apr 26, 9:57 AM
Unknown Object (File)
Wed, Apr 24, 6:59 PM
Unknown Object (File)
Wed, Apr 24, 10:35 AM
Unknown Object (File)
Mon, Apr 22, 8:06 AM
Subscribers

Details

Summary

Added unit tests for functions implemented in D7024

Depends on D7024
Depends on D7019

Test Plan

Ran these tests

Diff Detail

Repository
rCOMM Comm
Branch
barthap/aes-web
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Mar 9 2023, 11:11 PM

I'll add a test for the correct key, but the malformed ciphertext

Thanks for including these tests!

web/media/aes-crypto-utils.test.js
61–63 ↗(On Diff #23676)

Appreciate the comments explaining what you're doing with the bitwise operators

This revision is now accepted and ready to land.Mar 13 2023, 4:45 PM
This revision was automatically updated to reflect the committed changes.