[web-db] process redux-persist operations in SQLite
ClosedPublic
Actions

It seems like this diff does some moving/refactoring and also introduces some new stuff, which makes it hard to review. More context: https://www.notion.so/commapp/Moving-code-around-bbb551c4350b4d5cb553c6751be44314?pvs=4

separate code for two diffs

kamil added a child revision: D7248: [web-db] clean-up processing app requests on worker.Mar 30 2023, 2:22 AM

kamil removed a child revision: D7186: [web-db] start persisting SQLite content.Mar 30 2023, 2:24 AM

kamil added inline comments.

web/database/worker/db-worker.js
177 ↗	(On Diff #24375)	This code does not look good but it's addressed in D7248

Harbormaster completed remote builds in B17809: Diff 24375.Mar 30 2023, 2:37 AM

tomek accepted this revision.Mar 30 2023, 3:24 AM

This revision is now accepted and ready to land.Mar 30 2023, 3:24 AM

Closed by commit rCOMM6e9e7b457bb6: [web-db] process redux-persist operations in SQLite (authored by kamil). · Explain WhyMar 31 2023, 2:15 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM6e9e7b457bb6: [web-db] process redux-persist operations in SQLite.

kamil added a child revision: D7186: [web-db] start persisting SQLite content.Mar 31 2023, 2:36 AM

kamil removed a child revision: D7186: [web-db] start persisting SQLite content.Mar 31 2023, 2:37 AM

kamil added a child revision: D7186: [web-db] start persisting SQLite content.Apr 3 2023, 2:11 AM

kamil removed a child revision: D7186: [web-db] start persisting SQLite content.Apr 3 2023, 2:12 AM

Revision Contents
Changeset List

Path

Size

web/

database/

worker/

db-worker.js

31 lines

types/

worker-types.js

33 lines

Diff 24464

View Options

web/database/worker/db-worker.js

				use clap::{Parser, Subcommand};
	use tonic::transport::Server;			use tonic::transport::Server;

				mod keygen;
				mod opaque;
	mod service;			mod service;

				use keygen::generate_and_persist_keypair;
	use service::{IdentityServiceServer, MyIdentityService};			use service::{IdentityServiceServer, MyIdentityService};

	const IDENTITY_SERVICE_SOCKET_ADDR: &str = "[::]:50051";			const IDENTITY_SERVICE_SOCKET_ADDR: &str = "[::]:50051";
				const DEFAULT_SECRETS_DIRECTORY: &str = "secrets";

				#[derive(Parser)]
				#[clap(author, version, about, long_about = None)]
				#[clap(propagate_version = true)]
				struct Cli {
				#[clap(subcommand)]
				command: Commands,
				}

				#[derive(Subcommand)]
				enum Commands {
				/// Runs the server
				Server,
				/// Generates and persists a keypair to use for PAKE registration and login
				Keygen {
				#[clap(short, long)]
				#[clap(default_value_t = String::from(DEFAULT_SECRETS_DIRECTORY))]
				dir: String,
				},
				}

	#[tokio::main]			#[tokio::main]
	async fn main() -> Result<(), Box<dyn std::error::Error>> {			async fn main() -> Result<(), Box<dyn std::error::Error>> {
				let cli = Cli::parse();
				match &cli.command {
				Commands::Keygen { dir } => {
				generate_and_persist_keypair(dir)?;
				}
				Commands::Server => {
	let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?;			let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?;
	let identity_service = MyIdentityService::default();			let identity_service = MyIdentityService::default();

	Server::builder()			Server::builder()
	.add_service(IdentityServiceServer::new(identity_service))			.add_service(IdentityServiceServer::new(identity_service))
	.serve(addr)			.serve(addr)
	.await?;			.await?;
				}
				}

	Ok(())			Ok(())
	}			}

View Options

web/types/worker-types.js

				use clap::{Parser, Subcommand};
	use tonic::transport::Server;			use tonic::transport::Server;

				mod keygen;
				mod opaque;
	mod service;			mod service;

				use keygen::generate_and_persist_keypair;
	use service::{IdentityServiceServer, MyIdentityService};			use service::{IdentityServiceServer, MyIdentityService};

	const IDENTITY_SERVICE_SOCKET_ADDR: &str = "[::]:50051";			const IDENTITY_SERVICE_SOCKET_ADDR: &str = "[::]:50051";
				const DEFAULT_SECRETS_DIRECTORY: &str = "secrets";

				#[derive(Parser)]
				#[clap(author, version, about, long_about = None)]
				#[clap(propagate_version = true)]
				struct Cli {
				#[clap(subcommand)]
				command: Commands,
				}

				#[derive(Subcommand)]
				enum Commands {
				/// Runs the server
				Server,
				/// Generates and persists a keypair to use for PAKE registration and login
				Keygen {
				#[clap(short, long)]
				#[clap(default_value_t = String::from(DEFAULT_SECRETS_DIRECTORY))]
				dir: String,
				},
				}

	#[tokio::main]			#[tokio::main]
	async fn main() -> Result<(), Box<dyn std::error::Error>> {			async fn main() -> Result<(), Box<dyn std::error::Error>> {
				let cli = Cli::parse();
				match &cli.command {
				Commands::Keygen { dir } => {
				generate_and_persist_keypair(dir)?;
				}
				Commands::Server => {
	let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?;			let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?;
	let identity_service = MyIdentityService::default();			let identity_service = MyIdentityService::default();

	Server::builder()			Server::builder()
	.add_service(IdentityServiceServer::new(identity_service))			.add_service(IdentityServiceServer::new(identity_service))
	.serve(addr)			.serve(addr)
	.await?;			.await?;
				}
				}

	Ok(())			Ok(())
	}			}

[web-db] process redux-persist operations in SQLiteClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24464

web/database/worker/db-worker.js

web/types/worker-types.js

[web-db] process redux-persist operations in SQLite
ClosedPublic
Actions

Revision Contents
Changeset List