Page MenuHomePhabricator
Differential D7185

[web-db] process redux-persist operations in SQLite
ClosedPublic
Actions

Authored by kamil on Mar 27 2023, 4:48 AM.
Tags
None
Referenced Files
F6182411: D7185.diff
Wed, Apr 23, 7:42 AM
Unknown Object (File)
Sat, Apr 19, 4:14 AM
Unknown Object (File)
Fri, Apr 18, 11:50 AM
Unknown Object (File)
Fri, Apr 18, 8:39 AM
Unknown Object (File)
Fri, Apr 18, 4:27 AM
Unknown Object (File)
Thu, Apr 17, 7:45 AM
Unknown Object (File)
Wed, Apr 9, 12:58 AM
Unknown Object (File)
Wed, Apr 9, 12:03 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
michal
tomek
marcin
Commits
rCOMM6e9e7b457bb6: [web-db] process redux-persist operations in SQLite
Summary

Processing operations for custom storage-engine

Depends on D7184

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Branch
db-web-7
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Mar 27 2023, 4:48 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 27 2023, 4:48 AM
kamil mentioned this in D7182: [web-db] implement setting/getting `currentUserID` on worker.Mar 27 2023, 4:49 AM
kamil mentioned this in D7186: [web-db] start persisting SQLite content.Mar 27 2023, 4:55 AM
kamil added a child revision: D7186: [web-db] start persisting SQLite content.Mar 27 2023, 4:57 AM
Harbormaster completed remote builds in B17659: Diff 24166.Mar 27 2023, 5:03 AM
kamil published this revision for review.Mar 27 2023, 5:06 AM
ashoat added a comment.Mar 27 2023, 3:52 PM

It seems like this diff does some moving/refactoring and also introduces some new stuff, which makes it hard to review. More context: https://www.notion.so/commapp/Moving-code-around-bbb551c4350b4d5cb553c6751be44314?pvs=4

kamil updated this revision to Diff 24375.Mar 30 2023, 2:21 AM

separate code for two diffs

kamil added a child revision: D7248: [web-db] clean-up processing app requests on worker.Mar 30 2023, 2:22 AM
kamil removed a child revision: D7186: [web-db] start persisting SQLite content.Mar 30 2023, 2:24 AM
kamil added inline comments.
web/database/worker/db-worker.js
177 ↗(On Diff #24375)

This code does not look good but it's addressed in D7248

Harbormaster completed remote builds in B17809: Diff 24375.Mar 30 2023, 2:37 AM
tomek accepted this revision.Mar 30 2023, 3:24 AM
This revision is now accepted and ready to land.Mar 30 2023, 3:24 AM
Closed by commit rCOMM6e9e7b457bb6: [web-db] process redux-persist operations in SQLite (authored by kamil). · Explain WhyMar 31 2023, 2:15 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM6e9e7b457bb6: [web-db] process redux-persist operations in SQLite.
kamil added a child revision: D7186: [web-db] start persisting SQLite content.Mar 31 2023, 2:36 AM
kamil removed a child revision: D7186: [web-db] start persisting SQLite content.Mar 31 2023, 2:37 AM
kamil added a child revision: D7186: [web-db] start persisting SQLite content.Apr 3 2023, 2:11 AM
kamil removed a child revision: D7186: [web-db] start persisting SQLite content.Apr 3 2023, 2:12 AM

Revision Contents
Changeset List

PathSize
web/
database/
worker/
69 lines
types/
33 lines

Diff 24166

View Options

web/database/worker/db-worker.js

Show All 13 Linesimport {
useModalContext, useModalContext,
type PushModal, type PushModal,
} from 'lib/components/modal-provider.react'; } from 'lib/components/modal-provider.react';
import { onScreenThreadInfos as onScreenThreadInfosSelector } from 'lib/selectors/thread-selectors'; import { onScreenThreadInfos as onScreenThreadInfosSelector } from 'lib/selectors/thread-selectors';
import { entryKey } from 'lib/shared/entry-utils'; import { entryKey } from 'lib/shared/entry-utils';
import type { EntryInfo } from 'lib/types/entry-types'; import type { EntryInfo } from 'lib/types/entry-types';
import type { Dispatch } from 'lib/types/redux-types'; import type { Dispatch } from 'lib/types/redux-types';
import type { ThreadInfo } from 'lib/types/thread-types'; import type { ThreadInfo } from 'lib/types/thread-types';
import { import { dateString, dateFromString } from 'lib/utils/date-utils';
dateString,
dateFromString,
currentDateInTimeZone,
} from 'lib/utils/date-utils';
import LogInFirstModal from '../modals/account/log-in-first-modal.react'; import LogInFirstModal from '../modals/account/log-in-first-modal.react';
import HistoryModal from '../modals/history/history-modal.react'; import HistoryModal from '../modals/history/history-modal.react';
import ThreadPickerModal from '../modals/threads/thread-picker-modal.react'; import ThreadPickerModal from '../modals/threads/thread-picker-modal.react';
import { useSelector } from '../redux/redux-utils'; import { useSelector } from '../redux/redux-utils';
import { htmlTargetFromEvent } from '../vector-utils'; import { htmlTargetFromEvent } from '../vector-utils';
import { AddVector, HistoryVector } from '../vectors.react'; import { AddVector, HistoryVector } from '../vectors.react';
import css from './calendar.css'; import css from './calendar.css';
import type { InnerEntry } from './entry.react'; import type { InnerEntry } from './entry.react';
import Entry from './entry.react'; import Entry from './entry.react';
type BaseProps = { type BaseProps = {
+dayString: string, +dayString: string,
+entryInfos: $ReadOnlyArray<EntryInfo>, +entryInfos: $ReadOnlyArray<EntryInfo>,
+startingTabIndex: number, +startingTabIndex: number,
}; };
type Props = { type Props = {
...BaseProps, ...BaseProps,
+onScreenThreadInfos: $ReadOnlyArray<ThreadInfo>, +onScreenThreadInfos: $ReadOnlyArray<ThreadInfo>,
+viewerID: ?string, +viewerID: ?string,
+loggedIn: boolean, +loggedIn: boolean,
+nextLocalID: number, +nextLocalID: number,
+timeZone: ?string,
+dispatch: Dispatch, +dispatch: Dispatch,
+pushModal: PushModal, +pushModal: PushModal,
+popModal: () => void, +popModal: () => void,
}; };
type State = { type State = {
+hovered: boolean, +hovered: boolean,
}; };
class Day extends React.PureComponent<Props, State> { class Day extends React.PureComponent<Props, State> {
state: State = { state: State = {
hovered: false, hovered: false,
}; };
entryContainer: ?HTMLDivElement; entryContainer: ?HTMLDivElement;
entryContainerSpacer: ?HTMLDivElement; entryContainerSpacer: ?HTMLDivElement;
actionLinks: ?HTMLDivElement; actionLinks: ?HTMLDivElement;
entries: Map<string, InnerEntry> = new Map(); entries: Map<string, InnerEntry> = new Map();
componentDidUpdate(prevProps: Props) { componentDidUpdate(prevProps: Props) {
if (this.props.entryInfos.length > prevProps.entryInfos.length) { if (this.props.entryInfos.length > prevProps.entryInfos.length) {
invariant(this.entryContainer, 'entryContainer ref not set'); invariant(this.entryContainer, 'entryContainer ref not set');
this.entryContainer.scrollTop = this.entryContainer.scrollHeight; this.entryContainer.scrollTop = this.entryContainer.scrollHeight;
} }
} }
render() { render() {
const now = currentDateInTimeZone(this.props.timeZone); const now = new Date();
const isToday = dateString(now) === this.props.dayString; const isToday = dateString(now) === this.props.dayString;
const tdClasses = classNames(css.day, { [css.currentDay]: isToday }); const tdClasses = classNames(css.day, { [css.currentDay]: isToday });
let actionLinks = null; let actionLinks = null;
const hovered = this.state.hovered; const hovered = this.state.hovered;
if (hovered) { if (hovered) {
const actionLinksClassName = `${css.actionLinks} ${css.dayActionLinks}`; const actionLinksClassName = `${css.actionLinks} ${css.dayActionLinks}`;
actionLinks = ( actionLinks = (
▲ Show 20 Lines • Show All 154 Lines • ▼ Show 20 Linesconst ConnectedDay: React.ComponentType<BaseProps> = React.memo<BaseProps>(
function ConnectedDay(props) { function ConnectedDay(props) {
const onScreenThreadInfos = useSelector(onScreenThreadInfosSelector); const onScreenThreadInfos = useSelector(onScreenThreadInfosSelector);
const viewerID = useSelector(state => state.currentUserInfo?.id); const viewerID = useSelector(state => state.currentUserInfo?.id);
const loggedIn = useSelector( const loggedIn = useSelector(
state => state =>
!!(state.currentUserInfo && !state.currentUserInfo.anonymous && true), !!(state.currentUserInfo && !state.currentUserInfo.anonymous && true),
); );
const nextLocalID = useSelector(state => state.nextLocalID); const nextLocalID = useSelector(state => state.nextLocalID);
const timeZone = useSelector(state => state.timeZone);
const dispatch = useDispatch(); const dispatch = useDispatch();
const { pushModal, popModal } = useModalContext(); const { pushModal, popModal } = useModalContext();
return ( return (
<Day <Day
{...props} {...props}
onScreenThreadInfos={onScreenThreadInfos} onScreenThreadInfos={onScreenThreadInfos}
viewerID={viewerID} viewerID={viewerID}
loggedIn={loggedIn} loggedIn={loggedIn}
nextLocalID={nextLocalID} nextLocalID={nextLocalID}
timeZone={timeZone}
dispatch={dispatch} dispatch={dispatch}
pushModal={pushModal} pushModal={pushModal}
popModal={popModal} popModal={popModal}
/> />
); );
}, },
); );
export default ConnectedDay; export default ConnectedDay;
View Options

web/types/worker-types.js

Show All 13 Linesimport {
useModalContext, useModalContext,
type PushModal, type PushModal,
} from 'lib/components/modal-provider.react'; } from 'lib/components/modal-provider.react';
import { onScreenThreadInfos as onScreenThreadInfosSelector } from 'lib/selectors/thread-selectors'; import { onScreenThreadInfos as onScreenThreadInfosSelector } from 'lib/selectors/thread-selectors';
import { entryKey } from 'lib/shared/entry-utils'; import { entryKey } from 'lib/shared/entry-utils';
import type { EntryInfo } from 'lib/types/entry-types'; import type { EntryInfo } from 'lib/types/entry-types';
import type { Dispatch } from 'lib/types/redux-types'; import type { Dispatch } from 'lib/types/redux-types';
import type { ThreadInfo } from 'lib/types/thread-types'; import type { ThreadInfo } from 'lib/types/thread-types';
import { import { dateString, dateFromString } from 'lib/utils/date-utils';
dateString,
dateFromString,
currentDateInTimeZone,
} from 'lib/utils/date-utils';
import LogInFirstModal from '../modals/account/log-in-first-modal.react'; import LogInFirstModal from '../modals/account/log-in-first-modal.react';
import HistoryModal from '../modals/history/history-modal.react'; import HistoryModal from '../modals/history/history-modal.react';
import ThreadPickerModal from '../modals/threads/thread-picker-modal.react'; import ThreadPickerModal from '../modals/threads/thread-picker-modal.react';
import { useSelector } from '../redux/redux-utils'; import { useSelector } from '../redux/redux-utils';
import { htmlTargetFromEvent } from '../vector-utils'; import { htmlTargetFromEvent } from '../vector-utils';
import { AddVector, HistoryVector } from '../vectors.react'; import { AddVector, HistoryVector } from '../vectors.react';
import css from './calendar.css'; import css from './calendar.css';
import type { InnerEntry } from './entry.react'; import type { InnerEntry } from './entry.react';
import Entry from './entry.react'; import Entry from './entry.react';
type BaseProps = { type BaseProps = {
+dayString: string, +dayString: string,
+entryInfos: $ReadOnlyArray<EntryInfo>, +entryInfos: $ReadOnlyArray<EntryInfo>,
+startingTabIndex: number, +startingTabIndex: number,
}; };
type Props = { type Props = {
...BaseProps, ...BaseProps,
+onScreenThreadInfos: $ReadOnlyArray<ThreadInfo>, +onScreenThreadInfos: $ReadOnlyArray<ThreadInfo>,
+viewerID: ?string, +viewerID: ?string,
+loggedIn: boolean, +loggedIn: boolean,
+nextLocalID: number, +nextLocalID: number,
+timeZone: ?string,
+dispatch: Dispatch, +dispatch: Dispatch,
+pushModal: PushModal, +pushModal: PushModal,
+popModal: () => void, +popModal: () => void,
}; };
type State = { type State = {
+hovered: boolean, +hovered: boolean,
}; };
class Day extends React.PureComponent<Props, State> { class Day extends React.PureComponent<Props, State> {
state: State = { state: State = {
hovered: false, hovered: false,
}; };
entryContainer: ?HTMLDivElement; entryContainer: ?HTMLDivElement;
entryContainerSpacer: ?HTMLDivElement; entryContainerSpacer: ?HTMLDivElement;
actionLinks: ?HTMLDivElement; actionLinks: ?HTMLDivElement;
entries: Map<string, InnerEntry> = new Map(); entries: Map<string, InnerEntry> = new Map();
componentDidUpdate(prevProps: Props) { componentDidUpdate(prevProps: Props) {
if (this.props.entryInfos.length > prevProps.entryInfos.length) { if (this.props.entryInfos.length > prevProps.entryInfos.length) {
invariant(this.entryContainer, 'entryContainer ref not set'); invariant(this.entryContainer, 'entryContainer ref not set');
this.entryContainer.scrollTop = this.entryContainer.scrollHeight; this.entryContainer.scrollTop = this.entryContainer.scrollHeight;
} }
} }
render() { render() {
const now = currentDateInTimeZone(this.props.timeZone); const now = new Date();
const isToday = dateString(now) === this.props.dayString; const isToday = dateString(now) === this.props.dayString;
const tdClasses = classNames(css.day, { [css.currentDay]: isToday }); const tdClasses = classNames(css.day, { [css.currentDay]: isToday });
let actionLinks = null; let actionLinks = null;
const hovered = this.state.hovered; const hovered = this.state.hovered;
if (hovered) { if (hovered) {
const actionLinksClassName = `${css.actionLinks} ${css.dayActionLinks}`; const actionLinksClassName = `${css.actionLinks} ${css.dayActionLinks}`;
actionLinks = ( actionLinks = (
▲ Show 20 Lines • Show All 154 Lines • ▼ Show 20 Linesconst ConnectedDay: React.ComponentType<BaseProps> = React.memo<BaseProps>(
function ConnectedDay(props) { function ConnectedDay(props) {
const onScreenThreadInfos = useSelector(onScreenThreadInfosSelector); const onScreenThreadInfos = useSelector(onScreenThreadInfosSelector);
const viewerID = useSelector(state => state.currentUserInfo?.id); const viewerID = useSelector(state => state.currentUserInfo?.id);
const loggedIn = useSelector( const loggedIn = useSelector(
state => state =>
!!(state.currentUserInfo && !state.currentUserInfo.anonymous && true), !!(state.currentUserInfo && !state.currentUserInfo.anonymous && true),
); );
const nextLocalID = useSelector(state => state.nextLocalID); const nextLocalID = useSelector(state => state.nextLocalID);
const timeZone = useSelector(state => state.timeZone);
const dispatch = useDispatch(); const dispatch = useDispatch();
const { pushModal, popModal } = useModalContext(); const { pushModal, popModal } = useModalContext();
return ( return (
<Day <Day
{...props} {...props}
onScreenThreadInfos={onScreenThreadInfos} onScreenThreadInfos={onScreenThreadInfos}
viewerID={viewerID} viewerID={viewerID}
loggedIn={loggedIn} loggedIn={loggedIn}
nextLocalID={nextLocalID} nextLocalID={nextLocalID}
timeZone={timeZone}
dispatch={dispatch} dispatch={dispatch}
pushModal={pushModal} pushModal={pushModal}
popModal={popModal} popModal={popModal}
/> />
); );
}, },
); );
export default ConnectedDay; export default ConnectedDay;