[web-db] add indexedDB config
ClosedPublic
Actions

Authored by kamil on Mar 7 2023, 8:45 AM.

Details

Reviewers

michal
tomek

Commits

rCOMMe8645d4fe752: [web-db] add indexedDB config

Summary

Adding config according to docs.

Test Plan

Run this code:

try {
  const value = await localforage.setItem('test', {
    prop: 'test prop',
  });
  console.log(value);
} catch (err) {
  console.log(err);
}

and check in devtools (web and desktop) if database was properly created

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

kamil held this revision as a draft.

kamil published this revision for review.Mar 7 2023, 10:06 AM

web/database/worker/web-db-worker.js
12 ↗	(On Diff #23508)	Is this version used e.g. for migrations?

web/database/worker/web-db-worker.js
12 ↗	(On Diff #23508)	It can be, but we won't use it for this purpose. For database (SQLite) versioning, we will use the same pattern as on native (`PRAGMA user_version;`). IndexedDB will be a key-value store with two keys and I don't think it'll ever need to migrate - if so I would introduce the keyserver's approach with an additional `metadata` key. Updating this version here will result in calling native callback upgradeneeded, but it's not that good, and `locaforage` as well as other similar libs does not supper this. Adding this here only for config types compatibility.