Page MenuHomePhabricator
Differential D7104

[web-db] add unit tests for worker crypto utils
ClosedPublic
Actions

Authored by kamil on Mar 20 2023, 9:12 AM.
Tags
None
Referenced Files
F3527771: D7104.diff
Tue, Dec 24, 6:39 AM
Unknown Object (File)
Sat, Dec 14, 4:28 PM
Unknown Object (File)
Sat, Dec 14, 4:28 PM
Unknown Object (File)
Sat, Dec 14, 4:28 PM
Unknown Object (File)
Sat, Dec 14, 4:28 PM
Unknown Object (File)
Sat, Dec 14, 4:27 PM
Unknown Object (File)
Sat, Dec 14, 4:18 PM
Unknown Object (File)
Sat, Dec 14, 2:29 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
bartek
michal
tomek
Commits
rCOMM83b3550cd01b: [web-db] add unit tests for worker crypto utils
Summary

Adding tests for crypto functions used to decrypt, encrypt, and initialize database.

Depends on D6996

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Mar 20 2023, 9:12 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 20 2023, 9:12 AM
kamil updated this revision to Diff 23873.Mar 20 2023, 9:14 AM

add blank line after // @flow

kamil edited parent revisions, added: D6995: [web-db] implement crypto functions; removed: D6996: [web-db] generate `CryptoKey` and persist.Mar 20 2023, 9:14 AM
kamil added a child revision: D6996: [web-db] generate `CryptoKey` and persist.
kamil mentioned this in D6995: [web-db] implement crypto functions.Mar 20 2023, 9:21 AM
kamil published this revision for review.Mar 20 2023, 9:26 AM
Harbormaster completed remote builds in B17419: Diff 23872.Mar 20 2023, 9:27 AM
Harbormaster completed remote builds in B17420: Diff 23873.
bartek accepted this revision.Mar 21 2023, 4:33 AM
This revision is now accepted and ready to land.Mar 21 2023, 4:33 AM
ashoat added inline comments.Mar 21 2023, 7:23 AM
web/database/utils/worker-crypto-utlis.test.js
18 ↗(On Diff #23873)

Is there any tag function we can use for SQLite?

kamil added inline comments.Mar 21 2023, 9:51 AM
web/database/utils/worker-crypto-utlis.test.js
18 ↗(On Diff #23873)

I didn't find anything worth using... I created follow-up task to take a look again: ENG-3370.

Right now I would prefer to proceed with this and use prepared statements like in D7122, is it okay for now?

ashoat added inline comments.Mar 22 2023, 11:37 AM
web/database/utils/worker-crypto-utlis.test.js
18 ↗(On Diff #23873)

Thanks for creating the task!! Prepared statements look safe against SQL injection attacks, so I think this is a good approach :)

kamil removed a child revision: D6996: [web-db] generate `CryptoKey` and persist.Mar 25 2023, 4:43 AM
kamil edited parent revisions, added: D6996: [web-db] generate `CryptoKey` and persist; removed: D6995: [web-db] implement crypto functions.
kamil updated this revision to Diff 24126.Mar 25 2023, 4:44 AM

rebase before landing

kamil added a comment.Mar 25 2023, 4:51 AM

FYI By mistake, two diffs had different order in the stack than in my branch on git - that's why I needed to fix parent/child revisions because arcanist didn't allow me to arc diff but this has no influence on the code itself

Harbormaster completed remote builds in B17629: Diff 24126.Mar 25 2023, 5:00 AM
Closed by commit rCOMM83b3550cd01b: [web-db] add unit tests for worker crypto utils (authored by kamil). · Explain WhyMar 25 2023, 5:01 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM83b3550cd01b: [web-db] add unit tests for worker crypto utils.

Revision Contents
Changeset List

PathSize
web/
database/
utils/
85 lines

Diff 24130

View Options

web/database/utils/worker-crypto-utlis.test.js

Loading...