web/database/utils/worker-crypto-utlis.test.js
18 ↗	(On Diff #23873)	I didn't find anything worth using... I created follow-up task to take a look again: ENG-3370. Right now I would prefer to proceed with this and use prepared statements like in D7122, is it okay for now?

ashoat added inline comments.Mar 22 2023, 11:37 AM

web/database/utils/worker-crypto-utlis.test.js
18 ↗	(On Diff #23873)	Thanks for creating the task!! Prepared statements look safe against SQL injection attacks, so I think this is a good approach :)

kamil removed a child revision: D6996: [web-db] generate `CryptoKey` and persist.Mar 25 2023, 4:43 AM

kamil edited parent revisions, added: D6996: [web-db] generate `CryptoKey` and persist; removed: D6995: [web-db] implement crypto functions.

rebase before landing

FYI By mistake, two diffs had different order in the stack than in my branch on git - that's why I needed to fix parent/child revisions because arcanist didn't allow me to arc diff but this has no influence on the code itself

Harbormaster completed remote builds in B17629: Diff 24126.Mar 25 2023, 5:00 AM

Closed by commit rCOMM83b3550cd01b: [web-db] add unit tests for worker crypto utils (authored by kamil). · Explain WhyMar 25 2023, 5:01 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM83b3550cd01b: [web-db] add unit tests for worker crypto utils.

Revision Contents
Changeset List

Path

Size

web/

database/

utils/

worker-crypto-utlis.test.js

85 lines

Diff 24130

View Options

web/database/utils/worker-crypto-utlis.test.js

	Show All 35 Lines
	import type { CommunityCreationMembersScreenParams } from '../community-creation/community-creation-members.react.js';			import type { CommunityCreationMembersScreenParams } from '../community-creation/community-creation-members.react.js';
	import type { ManagePublicLinkScreenParams } from '../invite-links/manage-public-link-screen.react.js';			import type { ManagePublicLinkScreenParams } from '../invite-links/manage-public-link-screen.react.js';
	import type { ViewInviteLinksScreenParams } from '../invite-links/view-invite-links-screen.react.js';			import type { ViewInviteLinksScreenParams } from '../invite-links/view-invite-links-screen.react.js';
	import type { ChatCameraModalParams } from '../media/chat-camera-modal.react.js';			import type { ChatCameraModalParams } from '../media/chat-camera-modal.react.js';
	import type { ImageModalParams } from '../media/image-modal.react.js';			import type { ImageModalParams } from '../media/image-modal.react.js';
	import type { ThreadAvatarCameraModalParams } from '../media/thread-avatar-camera-modal.react.js';			import type { ThreadAvatarCameraModalParams } from '../media/thread-avatar-camera-modal.react.js';
	import type { VideoPlaybackModalParams } from '../media/video-playback-modal.react.js';			import type { VideoPlaybackModalParams } from '../media/video-playback-modal.react.js';
	import type { CustomServerModalParams } from '../profile/custom-server-modal.react.js';			import type { CustomServerModalParams } from '../profile/custom-server-modal.react.js';
				import type { KeyserverSelectionBottomSheetParams } from '../profile/keyserver-selection-bottom-sheet.react.js';
	import type { UserRelationshipTooltipModalParams } from '../profile/user-relationship-tooltip-modal.react.js';			import type { UserRelationshipTooltipModalParams } from '../profile/user-relationship-tooltip-modal.react.js';
	import type { ChangeRolesScreenParams } from '../roles/change-roles-screen.react.js';			import type { ChangeRolesScreenParams } from '../roles/change-roles-screen.react.js';
	import type { CommunityRolesScreenParams } from '../roles/community-roles-screen.react.js';			import type { CommunityRolesScreenParams } from '../roles/community-roles-screen.react.js';
	import type { CreateRolesScreenParams } from '../roles/create-roles-screen.react.js';			import type { CreateRolesScreenParams } from '../roles/create-roles-screen.react.js';
	import type { MessageSearchParams } from '../search/message-search.react.js';			import type { MessageSearchParams } from '../search/message-search.react.js';
	import type { UserProfileAvatarModalParams } from '../user-profile/user-profile-avatar-modal.react.js';			import type { UserProfileAvatarModalParams } from '../user-profile/user-profile-avatar-modal.react.js';
	import type { UserProfileBottomSheetParams } from '../user-profile/user-profile-bottom-sheet.react.js';			import type { UserProfileBottomSheetParams } from '../user-profile/user-profile-bottom-sheet.react.js';

	▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines
	export const QRCodeSignInNavigatorRouteName = 'QRCodeSignInNavigator';			export const QRCodeSignInNavigatorRouteName = 'QRCodeSignInNavigator';
	export const QRCodeScreenRouteName = 'QRCodeScreen';			export const QRCodeScreenRouteName = 'QRCodeScreen';
	export const UserProfileBottomSheetNavigatorRouteName =			export const UserProfileBottomSheetNavigatorRouteName =
	'UserProfileBottomSheetNavigator';			'UserProfileBottomSheetNavigator';
	export const UserProfileBottomSheetRouteName = 'UserProfileBottomSheet';			export const UserProfileBottomSheetRouteName = 'UserProfileBottomSheet';
	export const UserProfileAvatarModalRouteName = 'UserProfileAvatarModal';			export const UserProfileAvatarModalRouteName = 'UserProfileAvatarModal';
	export const KeyserverSelectionListRouteName = 'KeyserverSelectionList';			export const KeyserverSelectionListRouteName = 'KeyserverSelectionList';
	export const AddKeyserverRouteName = 'AddKeyserver';			export const AddKeyserverRouteName = 'AddKeyserver';
				export const KeyserverSelectionBottomSheetRouteName =
				'KeyserverSelectionBottomSheet';

	export type RootParamList = {			export type RootParamList = {
	+LoggedOutModal: void,			+LoggedOutModal: void,
	+App: void,			+App: void,
	+ThreadPickerModal: ThreadPickerModalParams,			+ThreadPickerModal: ThreadPickerModalParams,
	+AddUsersModal: AddUsersModalParams,			+AddUsersModal: AddUsersModalParams,
	+CustomServerModal: CustomServerModalParams,			+CustomServerModal: CustomServerModalParams,
	+ColorSelectorModal: ColorSelectorModalParams,			+ColorSelectorModal: ColorSelectorModalParams,
	+ComposeSubchannelModal: ComposeSubchannelModalParams,			+ComposeSubchannelModal: ComposeSubchannelModalParams,
	+SidebarListModal: SidebarListModalParams,			+SidebarListModal: SidebarListModalParams,
	+ImagePasteModal: ImagePasteModalParams,			+ImagePasteModal: ImagePasteModalParams,
	+TermsAndPrivacyModal: TermsAndPrivacyModalParams,			+TermsAndPrivacyModal: TermsAndPrivacyModalParams,
	+SubchannelsListModal: SubchannelListModalParams,			+SubchannelsListModal: SubchannelListModalParams,
	+MessageReactionsModal: MessageReactionsModalParams,			+MessageReactionsModal: MessageReactionsModalParams,
	+Registration: void,			+Registration: void,
	+CommunityCreation: void,			+CommunityCreation: void,
	+InviteLinkModal: InviteLinkModalParams,			+InviteLinkModal: InviteLinkModalParams,
	+InviteLinkNavigator: void,			+InviteLinkNavigator: void,
	+RolesNavigator: void,			+RolesNavigator: void,
	+QRCodeSignInNavigator: void,			+QRCodeSignInNavigator: void,
	+UserProfileBottomSheetNavigator: void,			+UserProfileBottomSheetNavigator: void,
	+TunnelbrokerMenu: void,			+TunnelbrokerMenu: void,
				+KeyserverSelectionBottomSheet: KeyserverSelectionBottomSheetParams,
	};			};

	export type MessageTooltipRouteNames =			export type MessageTooltipRouteNames =
	\| typeof RobotextMessageTooltipModalRouteName			\| typeof RobotextMessageTooltipModalRouteName
	\| typeof MultimediaMessageTooltipModalRouteName			\| typeof MultimediaMessageTooltipModalRouteName
	\| typeof TextMessageTooltipModalRouteName;			\| typeof TextMessageTooltipModalRouteName;

	export const PinnableMessageTooltipRouteNames = [			export const PinnableMessageTooltipRouteNames = [
	▲ Show 20 Lines • Show All 161 Lines • Show Last 20 Lines

[web-db] add unit tests for worker crypto utilsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24130

web/database/utils/worker-crypto-utlis.test.js

[web-db] add unit tests for worker crypto utils
ClosedPublic
Actions

Revision Contents
Changeset List