Paths

Table of Contentst

-
web/database/queries/
-
database/
-
queries/
-
draft-queries.js

[web-db] implement Draft Store Operations
ClosedPublic
Actions

Authored by kamil on Mar 21 2023, 8:19 AM.

Details

Reviewers

michal
tomek
marcin
ashoat

Commits

rCOMM640ebb7a374d: [web-db] implement Draft Store Operations

Summary

SQL implementation of draft store operations.

Depends on D7121

Test Plan

Tests D7124

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mar 21 2023, 8:19 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 21 2023, 8:19 AM

kamil added inline comments.Mar 21 2023, 8:21 AM

web/database/queries/draft-queries.js
3 ↗	(On Diff #23931)	native version: link
7 ↗	(On Diff #23931)	native version: link
20 ↗	(On Diff #23931)	native version: link Return value is not used anywhere so skipping it

kamil added a child revision: D7123: [web-db] implement function get all drafts from SQLite.Mar 21 2023, 8:22 AM

kamil edited the test plan for this revision. (Show Details)Mar 21 2023, 8:24 AM

Harbormaster completed remote builds in B17472: Diff 23931.Mar 21 2023, 8:34 AM

kamil mentioned this in D7104: [web-db] add unit tests for worker crypto utils.Mar 21 2023, 9:51 AM

kamil published this revision for review.Mar 22 2023, 5:34 AM

ashoat accepted this revision.Mar 22 2023, 11:36 AM

ashoat added inline comments.

web/database/queries/draft-queries.js
4 ↗	(On Diff #23931)
9 ↗	(On Diff #23931)	Does this actually work in SQLite? In MySQL it would error because `key` is a reserved keyword

This revision is now accepted and ready to land.Mar 22 2023, 11:36 AM

add import, improve query format

web/database/queries/draft-queries.js
9 ↗	(On Diff #23931)	It works, I checked in D7124. It's the same engine as on native, since it works there it should work here. As far as I know, `KEY` is reserved in SQLite, not `key` (for `KEY` it fails).

Harbormaster completed remote builds in B17546: Diff 24021.Mar 23 2023, 6:15 AM

Closed by commit rCOMM640ebb7a374d: [web-db] implement Draft Store Operations (authored by kamil). · Explain WhyMar 30 2023, 1:24 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM640ebb7a374d: [web-db] implement Draft Store Operations.

Revision Contents
Changeset List

Path

Size

web/

database/

queries/

draft-queries.js

36 lines

Diff 24363

View Options

web/database/queries/draft-queries.js

#include <grpcpp/grpcpp.h>		#include <grpcpp/grpcpp.h>

namespace comm {		namespace comm {
namespace network {		namespace network {
namespace reactor {		namespace reactor {

template <class Request, class Response>		template <class Request, class Response>
class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> {		class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> {
grpc::Status status;		grpc::Status status = grpc::Status::OK;
bool done = false;		bool done = false;
bool initialized = 0;		bool initialized = 0;
Request request;		Request request;

public:		public:
Response response;		Response response;
grpc::ClientContext context;		grpc::ClientContext context;

void nextWrite();		void nextWrite();
void OnWriteDone(bool ok) override;		void OnWriteDone(bool ok) override;
void terminate(const grpc::Status &status);		void terminate(const grpc::Status &status);
bool isDone();		bool isDone();
void OnDone(const grpc::Status &status) override;		void OnDone(const grpc::Status &status) override;

virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0;		virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0;
		virtual void validate(){};
virtual void doneCallback(){};		virtual void doneCallback(){};
virtual void terminateCallback(){};		virtual void terminateCallback(){};
};		};

template <class Request, class Response>		template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::nextWrite() {		void ClientWriteReactorBase<Request, Response>::nextWrite() {
this->request = Request();		this->request = Request();
std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request);		std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request);
Show All 15 Lines	if (!ok) {
return;		return;
}		}
this->nextWrite();		this->nextWrite();
}		}

template <class Request, class Response>		template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::terminate(		void ClientWriteReactorBase<Request, Response>::terminate(
const grpc::Status &status) {		const grpc::Status &status) {
this->terminateCallback();		if (this->status.ok()) {
if (this->done) {		this->status = status;
return;
}		}
if (!this->status.ok()) {		if (!this->status.ok()) {
std::cout << "error: " << this->status.error_message() << std::endl;		std::cout << "error: " << this->status.error_message() << std::endl;
}		}
this->status = status;		if (this->done) {
		return;
		}
		this->terminateCallback();
		try {
		this->validate();
		} catch (std::runtime_error &e) {
		this->status = grpc::Status(grpc::StatusCode::INTERNAL, e.what());
		}
this->done = true;		this->done = true;
this->StartWritesDone();		this->StartWritesDone();
}		}

template <class Request, class Response>		template <class Request, class Response>
bool ClientWriteReactorBase<Request, Response>::isDone() {		bool ClientWriteReactorBase<Request, Response>::isDone() {
return this->done;		return this->done;
}		}
Show All 11 Lines

[web-db] implement Draft Store OperationsClosedPublicActions