Page MenuHomePhabricator

[web-db] implement Draft Store Operations
ClosedPublic

Authored by kamil on Mar 21 2023, 8:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 22, 9:55 AM
Unknown Object (File)
Sun, Jun 30, 11:37 PM
Unknown Object (File)
Sun, Jun 30, 2:07 PM
Unknown Object (File)
Wed, Jun 26, 2:51 PM
Unknown Object (File)
Wed, Jun 26, 2:51 PM
Unknown Object (File)
Wed, Jun 26, 2:51 PM
Unknown Object (File)
Wed, Jun 26, 2:46 PM
Unknown Object (File)
Sun, Jun 23, 7:21 PM
Subscribers

Details

Summary

SQL implementation of draft store operations.

Depends on D7121

Test Plan

Tests D7124

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
web/database/queries/draft-queries.js
3 ↗(On Diff #23931)

native version: link

7 ↗(On Diff #23931)

native version: link

20 ↗(On Diff #23931)

native version: link
Return value is not used anywhere so skipping it

kamil published this revision for review.Mar 22 2023, 5:34 AM
ashoat added inline comments.
web/database/queries/draft-queries.js
4 ↗(On Diff #23931)
9 ↗(On Diff #23931)

Does this actually work in SQLite? In MySQL it would error because key is a reserved keyword

This revision is now accepted and ready to land.Mar 22 2023, 11:36 AM

add import, improve query format

web/database/queries/draft-queries.js
9 ↗(On Diff #23931)

It works, I checked in D7124.

It's the same engine as on native, since it works there it should work here.

As far as I know, KEY is reserved in SQLite, not key (for KEY it fails).

This revision was automatically updated to reflect the committed changes.