Paths

Table of Contentst

Differential D7122

[web-db] implement Draft Store Operations
ClosedPublic
Actions

Authored by kamil on Mar 21 2023, 8:19 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 1:52 PM

	Unknown Object (File)
	Sat, Nov 23, 10:54 AM

	Unknown Object (File)
	Sat, Nov 23, 8:21 AM

	Unknown Object (File)
	Thu, Nov 7, 10:47 AM

	Unknown Object (File)
	Thu, Nov 7, 10:47 AM

	Unknown Object (File)
	Wed, Nov 6, 3:15 AM

	Unknown Object (File)
	Wed, Nov 6, 3:15 AM

	Unknown Object (File)
	Mon, Nov 4, 11:11 PM

Subscribers

Details

Reviewers

michal
tomek
marcin
ashoat

Commits

rCOMM640ebb7a374d: [web-db] implement Draft Store Operations

Summary

SQL implementation of draft store operations.

Depends on D7121

Test Plan

Tests D7124

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Mar 21 2023, 8:19 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 21 2023, 8:19 AM

kamil added inline comments.Mar 21 2023, 8:21 AM

web/database/queries/draft-queries.js
3	native version: link
7	native version: link
20	native version: link Return value is not used anywhere so skipping it

kamil added a child revision: D7123: [web-db] implement function get all drafts from SQLite.Mar 21 2023, 8:22 AM

kamil edited the test plan for this revision. (Show Details)Mar 21 2023, 8:24 AM

Harbormaster completed remote builds in B17472: Diff 23931.Mar 21 2023, 8:34 AM

kamil mentioned this in D7104: [web-db] add unit tests for worker crypto utils.Mar 21 2023, 9:51 AM

kamil published this revision for review.Mar 22 2023, 5:34 AM

ashoat accepted this revision.Mar 22 2023, 11:36 AM

ashoat added inline comments.

web/database/queries/draft-queries.js
4
9	Does this actually work in SQLite? In MySQL it would error because `key` is a reserved keyword

This revision is now accepted and ready to land.Mar 22 2023, 11:36 AM

add import, improve query format

web/database/queries/draft-queries.js
9	It works, I checked in D7124. It's the same engine as on native, since it works there it should work here. As far as I know, `KEY` is reserved in SQLite, not `key` (for `KEY` it fails).

Harbormaster completed remote builds in B17546: Diff 24021.Mar 23 2023, 6:15 AM

Closed by commit rCOMM640ebb7a374d: [web-db] implement Draft Store Operations (authored by kamil). · Explain WhyMar 30 2023, 1:24 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM640ebb7a374d: [web-db] implement Draft Store Operations.

Revision Contents
Changeset List

Path

Size

web/

database/

queries/

draft-queries.js

34 lines

Diff 23931

web/database/queries/draft-queries.js

Loading...