Page MenuHomePhabricator

[web-db] add table and operations for redux-persist engine
ClosedPublic

Authored by kamil on Mar 27 2023, 4:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 30, 11:38 PM
Unknown Object (File)
Wed, Jun 26, 2:52 PM
Unknown Object (File)
Wed, Jun 26, 2:52 PM
Unknown Object (File)
Wed, Jun 26, 2:52 PM
Unknown Object (File)
Wed, Jun 26, 2:46 PM
Unknown Object (File)
Tue, Jun 25, 6:24 AM
Unknown Object (File)
Mon, Jun 24, 10:00 AM
Unknown Object (File)
Jun 21 2024, 4:25 PM
Subscribers

Details

Summary

Supporting operations for custom storage-engine

NOTE: There is a code repetition between this and metadata because both are basically operations on a key-value table. Creating a task to unify this as a follow-up.
NOTE: D7121 is not landed yet, and even so, my local environment is the only place where this code was executed so adding this without migration.

Depends on D7182

Test Plan

Run tests D7184

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil edited the test plan for this revision. (Show Details)
web/database/queries/db-queries.js
33 ↗(On Diff #24164)

probably could allow nullable values here, but I checked redux-persist and tested custom engines and there will always be a value here

additionally - redux-persist handle converting objects to JSON string itself, so we can use TEXT

kamil published this revision for review.Mar 27 2023, 5:05 AM
ashoat added inline comments.
web/database/queries/db-queries.js
33 ↗(On Diff #24164)

Thanks for explaining!

web/database/queries/storage-engine-queries.js
27 ↗(On Diff #24164)

Nit: FROM persist_storage usually get its own line in our code

This revision is now accepted and ready to land.Mar 27 2023, 3:49 PM