[web-db] add table and operations for redux-persist engine
ClosedPublic
Actions

Authored by kamil on Mar 27 2023, 4:34 AM.

Details

Reviewers

michal
tomek
marcin
ashoat

Commits

rCOMM603ceea40cb4: [web-db] add table and operations for redux-persist engine

Summary

Supporting operations for custom storage-engine

NOTE: There is a code repetition between this and metadata because both are basically operations on a key-value table. Creating a task to unify this as a follow-up.

NOTE: D7121 is not landed yet, and even so, my local environment is the only place where this code was executed so adding this without migration.

Depends on D7182

Test Plan

Run tests D7184

Diff Detail

Repository

rCOMM Comm

Branch

land-db

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Mar 27 2023, 4:34 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 27 2023, 4:34 AM

kamil added a child revision: D7184: [web-db] add unit tests for redux-persist engine operations.Mar 27 2023, 4:38 AM

kamil edited the summary of this revision. (Show Details)Mar 27 2023, 4:41 AM

kamil edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B17657: Diff 24164.Mar 27 2023, 5:00 AM

kamil added inline comments.Mar 27 2023, 5:04 AM

web/database/queries/db-queries.js
33 ↗	(On Diff #24164)	probably could allow nullable values here, but I checked `redux-persist` and tested custom engines and there will always be a value here additionally - `redux-persist` handle converting objects to JSON string itself, so we can use `TEXT`

kamil published this revision for review.Mar 27 2023, 5:05 AM

ashoat accepted this revision.Mar 27 2023, 3:49 PM

ashoat added inline comments.

web/database/queries/db-queries.js
33 ↗	(On Diff #24164)	Thanks for explaining!
web/database/queries/storage-engine-queries.js
27 ↗	(On Diff #24164)	Nit: `FROM persist_storage` usually get its own line in our code