[web-db] read drafts from SQLite database and dispatch to store
ClosedPublic
Actions

Authored by kamil on Apr 27 2023, 7:38 AM.

Details

Reviewers

tomek
michal

Commits

rCOMM9d354fce587d: [web-db] read drafts from SQLite database and dispatch to store

Summary

Read drafts from database and propagate to redux store.

Depends on D7664

Test Plan

Reload web app
Log if drafts are queried properly
Check if the same drafts are visible in UI

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Apr 27 2023, 7:38 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 27 2023, 7:38 AM

kamil added a child revision: D7666: [web-db] stop persisting drafts in redux-persist.Apr 27 2023, 7:42 AM

Harbormaster completed remote builds in B18872: Diff 25850.Apr 27 2023, 7:56 AM

kamil published this revision for review.Apr 27 2023, 7:58 AM

tomek accepted this revision.Apr 28 2023, 4:29 AM

tomek added inline comments.

web/database/sqlite-data-handler.js
50–64 ↗	(On Diff #25850)	We have two ways of checking if a user is logged in in this effect: `if (currentLoggedInUserID)` and `if (!loggedIn)` - does it make sense to use both?

This revision is now accepted and ready to land.Apr 28 2023, 4:29 AM

address review, rebase before landing

Harbormaster completed remote builds in B19273: Diff 26375.May 11 2023, 3:48 AM

Closed by commit rCOMM9d354fce587d: [web-db] read drafts from SQLite database and dispatch to store (authored by kamil). · Explain WhyMay 11 2023, 4:03 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM9d354fce587d: [web-db] read drafts from SQLite database and dispatch to store.

Revision Contents
Changeset List

Path

Size

web/

database/

sqlite-data-handler.js

28 lines

Diff 26386

View Options

web/database/sqlite-data-handler.js

[web-db] read drafts from SQLite database and dispatch to storeClosedPublicActions