Page MenuHomePhabricator
Differential D6996

[web-db] generate `CryptoKey` and persist
ClosedPublic
Actions

Authored by kamil on Mar 7 2023, 9:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 16, 1:16 PM
Unknown Object (File)
Sat, Nov 2, 1:01 AM
Unknown Object (File)
Sat, Nov 2, 1:01 AM
Unknown Object (File)
Sat, Nov 2, 1:01 AM
Unknown Object (File)
Sat, Nov 2, 1:01 AM
Unknown Object (File)
Sat, Nov 2, 1:01 AM
Unknown Object (File)
Sat, Nov 2, 1:01 AM
Unknown Object (File)
Sat, Nov 2, 12:55 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
michal
tomek
Commits
rCOMMc6ea9a5a2f99: [web-db] generate `CryptoKey` and persist
Summary

Generating crypto key for user and persist in indexedDB.

Depends on D6995, D6993

Test Plan

Run this code:

await webDBWorker.scheduleOnWorker({
  type: workerRequestMessageTypes.GENERATE_CRYPTO_KEY,
});

in check in indexedDB devtools if crypto key is properly persisted

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Mar 7 2023, 9:39 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 7 2023, 9:39 AM
Harbormaster completed remote builds in B17172: Diff 23514.Mar 7 2023, 9:55 AM
kamil published this revision for review.Mar 7 2023, 10:10 AM
tomek added inline comments.Mar 8 2023, 4:57 AM
web/types/worker-types.js
7 ↗(On Diff #23514)

Can we make this more explicit and tell that it is database encryption key? I guess there might be some other crypto keys in the future.

kamil updated this revision to Diff 23603.Mar 10 2023, 7:18 AM

rebase, update const

web/types/worker-types.js
7 ↗(On Diff #23514)

Sure, good call

Harbormaster completed remote builds in B17233: Diff 23603.Mar 10 2023, 7:33 AM
kamil updated this revision to Diff 23698.Mar 13 2023, 8:48 AM

reabase

Harbormaster completed remote builds in B17299: Diff 23698.Mar 13 2023, 9:03 AM
michal accepted this revision.Mar 15 2023, 10:53 AM
This revision is now accepted and ready to land.Mar 15 2023, 10:53 AM
kamil updated this revision to Diff 23868.Mar 20 2023, 9:05 AM

rebase

kamil added a child revision: D7104: [web-db] add unit tests for worker crypto utils.Mar 20 2023, 9:12 AM
kamil removed a child revision: D7104: [web-db] add unit tests for worker crypto utils.Mar 20 2023, 9:14 AM
kamil edited parent revisions, added: D7104: [web-db] add unit tests for worker crypto utils; removed: D6995: [web-db] implement crypto functions.
Harbormaster completed remote builds in B17415: Diff 23868.Mar 20 2023, 9:20 AM
kamil removed a parent revision: D6993: [web-db] initialize SQLite database.Mar 20 2023, 9:23 AM
kamil updated this revision to Diff 24124.Mar 25 2023, 4:41 AM
kamil added parent revisions: D6995: [web-db] implement crypto functions, D6993: [web-db] initialize SQLite database.

rebase before landing

kamil removed parent revisions: D6993: [web-db] initialize SQLite database, D7104: [web-db] add unit tests for worker crypto utils.Mar 25 2023, 4:43 AM
kamil added a child revision: D7104: [web-db] add unit tests for worker crypto utils.
Harbormaster completed remote builds in B17627: Diff 24124.Mar 25 2023, 4:56 AM
Closed by commit rCOMMc6ea9a5a2f99: [web-db] generate `CryptoKey` and persist (authored by kamil). · Explain WhyMar 25 2023, 5:01 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMc6ea9a5a2f99: [web-db] generate `CryptoKey` and persist.

Revision Contents
Changeset List

PathSize
web/
database/
utils/
1 line
worker/
9 lines
types/
8 lines

Diff 24129

View Options

web/database/utils/constants.js

Loading...
View Options

web/database/worker/db-worker.js

Loading...
View Options

web/types/worker-types.js

Loading...