Page MenuHomePhabricator
Differential D7092

[web-db] Use unique filename for each prod `sql-wasm.wasm` asset
ClosedPublic
Actions

Authored by kamil on Mar 17 2023, 4:16 AM.
Tags
None
Referenced Files
F578581: D7092.id23820.diff
Thu, Jun 8, 10:49 AM
F578580: D7092.id.diff
Thu, Jun 8, 10:49 AM
Unknown Object (File)
Apr 3 2023, 7:36 PM
Unknown Object (File)
Mar 30 2023, 2:17 AM
Unknown Object (File)
Mar 28 2023, 10:02 AM
Unknown Object (File)
Mar 24 2023, 4:11 PM
Unknown Object (File)
Mar 21 2023, 4:08 PM
Unknown Object (File)
Mar 21 2023, 10:40 AM
View All 11 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
atul
Commits
rCOMM88db3ac63232: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset
Summary

ENG-3329

  • adding contenthash to sql.js asset file
  • adding mafiest plugin
Test Plan

Run in dev and prod modes, check if worker can access and use file

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Mar 17 2023, 4:16 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 17 2023, 4:16 AM
kamil mentioned this in D6993: [web-db] initialize SQLite database.Mar 17 2023, 4:18 AM
kamil added a child revision: D6993: [web-db] initialize SQLite database.Mar 17 2023, 4:19 AM
kamil added a comment.Mar 17 2023, 4:24 AM

Usage is described in D6993

kamil published this revision for review.Mar 17 2023, 4:29 AM
Harbormaster completed remote builds in B17385: Diff 23820.Mar 17 2023, 4:31 AM
michal accepted this revision.Mar 17 2023, 5:52 AM
This revision is now accepted and ready to land.Mar 17 2023, 5:52 AM
ashoat added inline comments.Mar 17 2023, 6:23 AM
keyserver/src/responders/website-responders.js
435 ↗(On Diff #23820)

Where do we consume this?

web/webpack.config.cjs
136 ↗(On Diff #23820)

Can you share an example of the contents of this file?

ashoat added inline comments.Mar 17 2023, 6:24 AM
keyserver/src/responders/website-responders.js
435 ↗(On Diff #23820)

Ah I see, D6993 explains

kamil added inline comments.Mar 17 2023, 6:46 AM
web/webpack.config.cjs
136 ↗(On Diff #23820)

sure:

{
  "pushNotif.js": "pushNotif.build.js",
  "database.js": "database.build.js",
  "sql-wasm.wasm": "sql-wasm.057823fecaed.wasm"
}

(just reminding that this is the file in webworkers directory so it's not overriding manifest.json where olm is defined)

ashoat added inline comments.Mar 17 2023, 8:20 AM
web/webpack.config.cjs
136 ↗(On Diff #23820)

Looks good!

Closed by commit rCOMM88db3ac63232: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset (authored by kamil). · Explain WhyMar 20 2023, 3:40 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM88db3ac63232: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
12 lines
web/
47 lines

Diff 23835

View Options

keyserver/src/responders/website-responders.js

Loading...
View Options

web/webpack.config.cjs

Loading...