Page MenuHomePhabricator
Differential D7666

[web-db] stop persisting drafts in redux-persist
ClosedPublic
Actions

Authored by kamil on Apr 27 2023, 7:42 AM.
Tags
None
Referenced Files
F5891618: D7666.diff
Thu, Apr 17, 7:40 AM
Unknown Object (File)
Sat, Apr 12, 3:12 PM
Unknown Object (File)
Wed, Apr 9, 2:23 PM
Unknown Object (File)
Wed, Apr 9, 2:01 AM
Unknown Object (File)
Tue, Apr 8, 11:30 PM
Unknown Object (File)
Tue, Apr 8, 9:11 PM
Unknown Object (File)
Tue, Apr 8, 9:10 PM
Unknown Object (File)
Fri, Mar 28, 8:49 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
Commits
rCOMMdeafcc719978: [web-db] stop persisting drafts in redux-persist
Summary

Drafts are now in SQLite - we can remove those from redux-persist (only for staff).

Depends on D7665

Test Plan

Check if drafts still works and are not persisted via redux-persist.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Apr 27 2023, 7:42 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 27 2023, 7:42 AM
kamil added a child revision: D7667: [web-db] choose storage engine depending on whether database is supported or not.Apr 27 2023, 7:47 AM
kamil published this revision for review.Apr 27 2023, 7:59 AM
Harbormaster completed remote builds in B18873: Diff 25851.Apr 27 2023, 8:01 AM
ashoat added inline comments.Apr 27 2023, 1:55 PM
web/root.js
29 ↗(On Diff #25851)

To make it clear that this only reflects the state at the start of execution, maybe we rename this variable

tomek accepted this revision.Apr 28 2023, 4:35 AM
This revision is now accepted and ready to land.Apr 28 2023, 4:35 AM
kamil mentioned this in D7660: [web-db] migrate drafts to SQLite.May 8 2023, 3:41 AM
kamil updated this revision to Diff 26376.May 11 2023, 3:32 AM

address review, rebase before landing

Harbormaster completed remote builds in B19274: Diff 26376.May 11 2023, 3:51 AM
Closed by commit rCOMMdeafcc719978: [web-db] stop persisting drafts in redux-persist (authored by kamil). · Explain WhyMay 11 2023, 4:03 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMdeafcc719978: [web-db] stop persisting drafts in redux-persist.

Revision Contents
Changeset List

PathSize
web/
30 lines

Diff 26387

View Options

web/root.js

#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
template <class Request, class Response> template <class Request, class Response>
class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> { class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> {
grpc::Status status; grpc::Status status = grpc::Status::OK;
bool done = false; bool done = false;
bool initialized = 0; bool initialized = 0;
Request request; Request request;
public: public:
Response response; Response response;
grpc::ClientContext context; grpc::ClientContext context;
void nextWrite(); void nextWrite();
void OnWriteDone(bool ok) override; void OnWriteDone(bool ok) override;
void terminate(const grpc::Status &status); void terminate(const grpc::Status &status);
bool isDone(); bool isDone();
void OnDone(const grpc::Status &status) override; void OnDone(const grpc::Status &status) override;
virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0; virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0;
virtual void validate(){};
virtual void doneCallback(){}; virtual void doneCallback(){};
virtual void terminateCallback(){}; virtual void terminateCallback(){};
}; };
template <class Request, class Response> template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::nextWrite() { void ClientWriteReactorBase<Request, Response>::nextWrite() {
this->request = Request(); this->request = Request();
std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request); std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request);
Show All 15 Lines if (!ok) {
return; return;
} }
this->nextWrite(); this->nextWrite();
} }
template <class Request, class Response> template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::terminate( void ClientWriteReactorBase<Request, Response>::terminate(
const grpc::Status &status) { const grpc::Status &status) {
this->terminateCallback(); if (this->status.ok()) {
if (this->done) { this->status = status;
return;
} }
if (!this->status.ok()) { if (!this->status.ok()) {
std::cout << "error: " << this->status.error_message() << std::endl; std::cout << "error: " << this->status.error_message() << std::endl;
} }
this->status = status; if (this->done) {
return;
}
this->terminateCallback();
try {
this->validate();
} catch (std::runtime_error &e) {
this->status = grpc::Status(grpc::StatusCode::INTERNAL, e.what());
}
this->done = true; this->done = true;
this->StartWritesDone(); this->StartWritesDone();
} }
template <class Request, class Response> template <class Request, class Response>
bool ClientWriteReactorBase<Request, Response>::isDone() { bool ClientWriteReactorBase<Request, Response>::isDone() {
return this->done; return this->done;
} }
Show All 11 Lines