[web-db] stop persisting drafts in redux-persist
ClosedPublic
Actions

Authored by kamil on Apr 27 2023, 7:42 AM.

Details

Reviewers

tomek
michal

Commits

rCOMMdeafcc719978: [web-db] stop persisting drafts in redux-persist

Summary

Drafts are now in SQLite - we can remove those from redux-persist (only for staff).

Depends on D7665

Test Plan

Check if drafts still works and are not persisted via redux-persist.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Apr 27 2023, 7:42 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 27 2023, 7:42 AM

kamil added a child revision: D7667: [web-db] choose storage engine depending on whether database is supported or not.Apr 27 2023, 7:47 AM

kamil published this revision for review.Apr 27 2023, 7:59 AM

Harbormaster completed remote builds in B18873: Diff 25851.Apr 27 2023, 8:01 AM

ashoat added inline comments.Apr 27 2023, 1:55 PM

web/root.js
29 ↗	(On Diff #25851)	To make it clear that this only reflects the state at the start of execution, maybe we rename this variable

tomek accepted this revision.Apr 28 2023, 4:35 AM

This revision is now accepted and ready to land.Apr 28 2023, 4:35 AM

kamil mentioned this in D7660: [web-db] migrate drafts to SQLite.May 8 2023, 3:41 AM

address review, rebase before landing

Harbormaster completed remote builds in B19274: Diff 26376.May 11 2023, 3:51 AM

Closed by commit rCOMMdeafcc719978: [web-db] stop persisting drafts in redux-persist (authored by kamil). · Explain WhyMay 11 2023, 4:03 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMdeafcc719978: [web-db] stop persisting drafts in redux-persist.

Revision Contents
Changeset List

Path

Size

web/

root.js

30 lines

Diff 26387

View Options

[web-db] stop persisting drafts in redux-persistClosedPublicActions