[web-db] choose storage engine depending on whether database is supported or not
ClosedPublic
Actions

Authored by kamil on Apr 27 2023, 7:47 AM.

Details

Reviewers

tomek
michal

Commits

rCOMMfd0203f1c83a: [web-db] choose storage engine depending on whether database is supported or not

Summary

Conditionally use default persist storage API or database depending on whether database is supported or not.

Depends on D7666

Test Plan

Switch to commReduxStorageEngine and test if it works for not supported database

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Apr 27 2023, 7:47 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 27 2023, 7:47 AM

kamil added a child revision: D7668: [web-db] migrate entire redux-persist storage to SQLite.Apr 27 2023, 7:50 AM

kamil published this revision for review.Apr 27 2023, 8:00 AM

Harbormaster completed remote builds in B18875: Diff 25853.Apr 27 2023, 8:04 AM

Wondering if this is the best solution. How about having two separate storage engines, one with only db and one with redux storage? Then we could conditionally set one or the other, but each of them would be a lot simpler.

This revision is now accepted and ready to land.Apr 28 2023, 4:37 AM

tomek added inline comments.Apr 28 2023, 4:38 AM

web/redux/comm-redux-storage-engine.js
3 ↗	(On Diff #25853)	Is this the right import? Do we have to include `index` in the path?

ashoat added inline comments.Apr 28 2023, 6:01 AM

web/redux/comm-redux-storage-engine.js
3 ↗	(On Diff #25853)	We have an ESLint rule that forces this. It can be ignored, but generally prefer to use `index.js` instead. This is the same import path we use in `web/root.js` currently