Page MenuHomePhabricator
Differential D7079

[lib] Don't refer to children of GENESIS as channels
ClosedPublic
Actions

Authored by ashoat on Mar 15 2023, 12:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 12:19 AM
Unknown Object (File)
Fri, Nov 22, 12:19 AM
Unknown Object (File)
Fri, Nov 22, 12:19 AM
Unknown Object (File)
Fri, Nov 22, 12:18 AM
Unknown Object (File)
Mon, Nov 4, 11:34 PM
Unknown Object (File)
Mon, Nov 4, 11:34 PM
Unknown Object (File)
Mon, Nov 4, 11:34 PM
Unknown Object (File)
Mon, Nov 4, 11:34 PM
View All 97 Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM8a45f64f5cf9: [lib] Don't refer to children of GENESIS as channels
Summary

Prefer "chat" since GENESIS children are stand-ins for DMs.

Depends on D7078

Test Plan

Tested in combination with the next two diffs:

  1. Make sure that robotext for chat creation of GENESIS subchannels calls them "chats"
  2. Make sure that robotext for chat creation of non-GENESIS subchannels calls them "channels"
  3. Make sure that notifs for chat creation of GENESIS subchannels calls them "chats"
  4. Make sure that notifs for chat creation of GENESIS subchannels doesn't mention GENESIS

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
2 lines
7 lines
utils/
5 lines

Diff 23800

View Options

lib/shared/notif-utils.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/utils/entity-text.js

Loading...