Differential D7079

[lib] Don't refer to children of GENESIS as channels
ClosedPublic
Actions

Authored by ashoat on Mar 15 2023, 7:16 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

atul
ginsu

Commits

rCOMM8a45f64f5cf9: [lib] Don't refer to children of GENESIS as channels

Summary

Prefer "chat" since GENESIS children are stand-ins for DMs.

Depends on D7078

Test Plan

Tested in combination with the next two diffs:

Make sure that robotext for chat creation of GENESIS subchannels calls them "chats"
Make sure that robotext for chat creation of non-GENESIS subchannels calls them "channels"
Make sure that notifs for chat creation of GENESIS subchannels calls them "chats"
Make sure that notifs for chat creation of GENESIS subchannels doesn't mention GENESIS

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 15 2023, 7:16 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 15 2023, 7:16 PM

ashoat added a child revision: D7080: [lib] Don't mention GENESIS in chat creation notifs.Mar 15 2023, 7:16 PM

Harbormaster completed remote builds in B17350: Diff 23767.Mar 15 2023, 7:35 PM

ashoat requested review of this revision.Mar 15 2023, 7:35 PM

atul accepted this revision.Mar 16 2023, 7:56 PM

This revision is now accepted and ready to land.Mar 16 2023, 7:56 PM

Closed by commit rCOMM8a45f64f5cf9: [lib] Don't refer to children of GENESIS as channels. · Explain WhyMar 16 2023, 9:32 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8a45f64f5cf9: [lib] Don't refer to children of GENESIS as channels.

Revision Contents
Changeset List

Path

Size

lib/

shared/

2 lines

thread-utils.js

7 lines

utils/

5 lines

Diff 23800

lib/shared/notif-utils.js

Loading...

lib/shared/thread-utils.js

Loading...

lib/utils/entity-text.js

Loading...