Page MenuHomePhabricator

[lib] Pass threadType and parentThreadID to alwaysDisplayShortName ThreadEntity
ClosedPublic

Authored by ashoat on Wed, Mar 15, 12:15 PM.
Tags
None
Referenced Files
F445288: D7078.id23766.diff
Sat, Mar 25, 7:31 PM
Unknown Object (File)
Sat, Mar 25, 6:48 AM
Unknown Object (File)
Fri, Mar 24, 7:28 AM
Unknown Object (File)
Tue, Mar 21, 1:10 AM
Unknown Object (File)
Tue, Mar 21, 1:10 AM
Unknown Object (File)
Tue, Mar 21, 1:06 AM
Unknown Object (File)
Mon, Mar 20, 10:25 PM
Unknown Object (File)
Mon, Mar 20, 8:37 PM
Subscribers

Details

Summary

We need these params for threadNoun to be able to accurately pick a noun for thread.

We already pass threadType (when available) to threadNoun, so including that should "automatically" improve things.

parentThreadID is new, as is necessary to differentiate children of GENESIS from children of other communities. The following diff will update threadNoun to look at that.

Test Plan

Tested in combination with the next two diffs:

  1. Make sure that robotext for chat creation of GENESIS subchannels calls them "chats"
  2. Make sure that robotext for chat creation of non-GENESIS subchannels calls them "channels"
  3. Make sure that notifs for chat creation of GENESIS subchannels calls them "chats"
  4. Make sure that notifs for chat creation of GENESIS subchannels doesn't mention GENESIS

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable