Page MenuHomePhabricator

[lib] Pass threadType and parentThreadID to alwaysDisplayShortName ThreadEntity
ClosedPublic

Authored by ashoat on Mar 15 2023, 12:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 3:57 AM
Unknown Object (File)
Thu, Mar 7, 3:57 AM
Unknown Object (File)
Thu, Mar 7, 3:57 AM
Unknown Object (File)
Feb 22 2024, 4:21 PM
Unknown Object (File)
Feb 22 2024, 1:37 PM
Unknown Object (File)
Feb 22 2024, 11:56 AM
Unknown Object (File)
Feb 22 2024, 3:47 AM
Unknown Object (File)
Feb 22 2024, 1:09 AM
Subscribers

Details

Summary

We need these params for threadNoun to be able to accurately pick a noun for thread.

We already pass threadType (when available) to threadNoun, so including that should "automatically" improve things.

parentThreadID is new, as is necessary to differentiate children of GENESIS from children of other communities. The following diff will update threadNoun to look at that.

Test Plan

Tested in combination with the next two diffs:

  1. Make sure that robotext for chat creation of GENESIS subchannels calls them "chats"
  2. Make sure that robotext for chat creation of non-GENESIS subchannels calls them "channels"
  3. Make sure that notifs for chat creation of GENESIS subchannels calls them "chats"
  4. Make sure that notifs for chat creation of GENESIS subchannels doesn't mention GENESIS

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage