Page MenuHomePhabricator

[lib] Don't mention GENESIS in chat creation notifs
ClosedPublic

Authored by ashoat on Mar 15 2023, 12:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 22, 3:41 PM
Unknown Object (File)
Thu, Feb 22, 3:28 PM
Unknown Object (File)
Thu, Feb 22, 1:37 PM
Unknown Object (File)
Thu, Feb 22, 3:47 AM
Unknown Object (File)
Tue, Feb 20, 8:36 AM
Unknown Object (File)
Wed, Feb 7, 3:45 AM
Unknown Object (File)
Mon, Feb 5, 12:32 AM
Unknown Object (File)
Mon, Feb 5, 12:32 AM
Subscribers

Details

Summary

Children of GENESIS are meant to be stand-ins for DMs, so when they are created we shouldn't mention GENESIS.

Depends on D7079

Test Plan

Tested in combination with the next two diffs:

  1. Make sure that robotext for chat creation of GENESIS subchannels calls them "chats"
  2. Make sure that robotext for chat creation of non-GENESIS subchannels calls them "channels"
  3. Make sure that notifs for chat creation of GENESIS subchannels calls them "chats"
  4. Make sure that notifs for chat creation of GENESIS subchannels doesn't mention GENESIS

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat retitled this revision from [lib] Don't message GENESIS in chat creation notifs to [lib] Don't mention GENESIS in chat creation notifs.Mar 15 2023, 12:23 PM
This revision is now accepted and ready to land.Mar 16 2023, 12:56 PM