[lib] Don't mention GENESIS in chat creation notifs
ClosedPublic
Actions

Authored by ashoat on Mar 15 2023, 12:16 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMMe6395952c5fc: [lib] Don't mention GENESIS in chat creation notifs

Summary

Children of GENESIS are meant to be stand-ins for DMs, so when they are created we shouldn't mention GENESIS.

Depends on D7079

Test Plan

Tested in combination with the next two diffs:

Make sure that robotext for chat creation of GENESIS subchannels calls them "chats"
Make sure that robotext for chat creation of non-GENESIS subchannels calls them "channels"
Make sure that notifs for chat creation of GENESIS subchannels calls them "chats"
Make sure that notifs for chat creation of GENESIS subchannels doesn't mention GENESIS

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 15 2023, 12:16 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 15 2023, 12:16 PM

ashoat retitled this revision from [lib] Don't message GENESIS in chat creation notifs to [lib] Don't mention GENESIS in chat creation notifs.Mar 15 2023, 12:23 PM

Harbormaster completed remote builds in B17351: Diff 23768.Mar 15 2023, 12:35 PM

ashoat requested review of this revision.Mar 15 2023, 12:35 PM

atul accepted this revision.Mar 16 2023, 12:56 PM

This revision is now accepted and ready to land.Mar 16 2023, 12:56 PM

Closed by commit rCOMMe6395952c5fc: [lib] Don't mention GENESIS in chat creation notifs (authored by ashoat). · Explain WhyMar 16 2023, 2:32 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe6395952c5fc: [lib] Don't mention GENESIS in chat creation notifs.