Paths

Table of Contentst

Differential D7078

[lib] Pass threadType and parentThreadID to alwaysDisplayShortName ThreadEntity
ClosedPublic
Actions

Authored by ashoat on Mar 15 2023, 12:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 22, 12:19 AM

	Unknown Object (File)
	Fri, Nov 22, 12:19 AM

	Unknown Object (File)
	Fri, Nov 22, 12:19 AM

	Unknown Object (File)
	Fri, Nov 22, 12:18 AM

	Unknown Object (File)
	Mon, Nov 11, 12:04 AM

	Unknown Object (File)
	Mon, Nov 4, 11:34 PM

	Unknown Object (File)
	Mon, Nov 4, 11:34 PM

	Unknown Object (File)
	Mon, Nov 4, 11:34 PM

View All 93 Files

Subscribers

Details

Reviewers

atul
ginsu

Commits

rCOMMa8e48f162d74: [lib] Pass threadType and parentThreadID to alwaysDisplayShortName ThreadEntity

Summary

We need these params for threadNoun to be able to accurately pick a noun for thread.

We already pass threadType (when available) to threadNoun, so including that should "automatically" improve things.

parentThreadID is new, as is necessary to differentiate children of GENESIS from children of other communities. The following diff will update threadNoun to look at that.

Test Plan

Tested in combination with the next two diffs:

Make sure that robotext for chat creation of GENESIS subchannels calls them "chats"
Make sure that robotext for chat creation of non-GENESIS subchannels calls them "channels"
Make sure that notifs for chat creation of GENESIS subchannels calls them "chats"
Make sure that notifs for chat creation of GENESIS subchannels doesn't mention GENESIS

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 15 2023, 12:15 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 15 2023, 12:15 PM

ashoat added a child revision: D7079: [lib] Don't refer to children of GENESIS as channels.Mar 15 2023, 12:16 PM

Harbormaster completed remote builds in B17349: Diff 23766.Mar 15 2023, 12:32 PM

ashoat requested review of this revision.Mar 15 2023, 12:32 PM

atul accepted this revision.Mar 16 2023, 8:23 AM

This revision is now accepted and ready to land.Mar 16 2023, 8:23 AM

Closed by commit rCOMMa8e48f162d74: [lib] Pass threadType and parentThreadID to alwaysDisplayShortName ThreadEntity (authored by ashoat). · Explain WhyMar 16 2023, 2:32 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa8e48f162d74: [lib] Pass threadType and parentThreadID to alwaysDisplayShortName ThreadEntity.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

change-settings-message-spec.js

30 lines

create-sidebar-message-spec.js

8 lines

create-thread-message-spec.js

8 lines

join-thread-message-spec.js

9 lines

leave-thread-message-spec.js

9 lines

utils/

10 lines

Diff 23799

lib/shared/messages/change-settings-message-spec.js

Loading...

lib/shared/messages/create-sidebar-message-spec.js

Loading...

lib/shared/messages/create-thread-message-spec.js

Loading...

lib/shared/messages/join-thread-message-spec.js

Loading...

lib/shared/messages/leave-thread-message-spec.js

Loading...

lib/utils/entity-text.js

Loading...