Paths

Table of Contentst

Differential D7083

Amended Account & Session types.
ClosedPublic
Actions

Authored by anunay on Mar 16 2023, 9:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 6, 3:37 PM

	Unknown Object (File)
	Wed, Nov 6, 3:37 PM

	Unknown Object (File)
	Mon, Nov 4, 11:36 PM

	Unknown Object (File)
	Mon, Nov 4, 11:35 PM

	Unknown Object (File)
	Mon, Nov 4, 11:35 PM

	Unknown Object (File)
	Sat, Nov 2, 12:30 AM

	Unknown Object (File)
	Sat, Nov 2, 12:30 AM

	Unknown Object (File)
	Sat, Nov 2, 12:30 AM

Subscribers

Details

Reviewers

Commits

rCOMMa43833d22c7d: Amended Account & Session types.

Test Plan

Tests are currently failing.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

anunay created this revision.Mar 16 2023, 9:17 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 16 2023, 9:17 AM

Harbormaster completed remote builds in B17362: Diff 23788.Mar 16 2023, 9:32 AM

anunay requested review of this revision.Mar 16 2023, 9:32 AM

We'll also need to update:

https://github.com/CommE2E/comm/blob/master/native/package.json#L87 <-- this one is easy
https://github.com/CommE2E/comm/blob/master/keyserver/package.json#L44 <-- probably easiest to publish our own version and just consume that
https://github.com/CommE2E/comm/blob/master/web/package.json#L60 <-- probably easiest to publish our own version and just consume that

This is how to release: https://gitlab.matrix.org/matrix-org/olm#release-process

This revision now requires changes to proceed.Mar 16 2023, 11:11 AM

@anunay also talked about adding some JS tests, but we can sequence that later

ashoat added a child revision: D7089: [web][keyserver] Fork Olm.Mar 16 2023, 6:41 PM

Add keyserver types as well

I handled my first comment in D7089, and added tests in D7090. I also updated this diff to include the libdef in keyserver

This revision is now accepted and ready to land.Mar 16 2023, 6:59 PM

Harbormaster completed remote builds in B17377: Diff 23810.Mar 16 2023, 7:11 PM

ashoat added inline comments.Mar 23 2023, 8:02 AM

keyserver/flow-typed/npm/@matrix-org/olm_vx.x.x.js
35 ↗	(On Diff #23810)	Changes we might need here if we take the "caller owns rotation" approach: Change to the `Account` struct in C++ to track published time of the latest prekey Change to the `PreKey` struct in C++ to have a `published` boolean (could be merged with 1 by tracking `publish_time` on a `PreKey` basis) Either a new API for marking latest prekey as published, or use existing `mark_keys_as_published` API for this An API for getting the unpublished latest key. If the latest key is already published, it returns nothing An API for getting the publish time of the latest prekey

Add signatures for @anunay's new methods

Two quick notes:

I think we're still missing get_unpublished_prekey_json here – see my GitHub PR comment for more details
This diff appears to modify the libdef for @matrix-org/olm, but in reality it only applies to @commapp/olm. Later diffs in this stack swap out the former for the latter, so this diff should not be landed without the rest of the diffs in the stack

Harbormaster completed remote builds in B18055: Diff 24741.Apr 6 2023, 12:20 PM

Add unpublished_prekey

Harbormaster completed remote builds in B18184: Diff 24898.Apr 10 2023, 9:52 AM

Closed by commit rCOMMa43833d22c7d: Amended Account & Session types. (authored by anunay, committed by ashoat). · Explain WhyApr 10 2023, 10:22 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa43833d22c7d: Amended Account & Session types..

Revision Contents
Changeset List

Path

Size

keyserver/

flow-typed/

npm/

@matrix-org/

7 lines

web/

flow-typed/

npm/

@matrix-org/

7 lines

Diff 24905

keyserver/flow-typed/npm/@matrix-org/olm_vx.x.x.js

Loading...

web/flow-typed/npm/@matrix-org/olm_vx.x.x.js

Loading...