Page MenuHomePhabricator
Differential D7083

Amended Account & Session types.
AcceptedPublic
Actions

Authored by anunay on Thu, Mar 16, 9:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 24, 10:47 AM
Unknown Object (File)
Mon, Mar 20, 3:27 AM
Unknown Object (File)
Mon, Mar 20, 3:27 AM
Unknown Object (File)
Mon, Mar 20, 3:27 AM
Unknown Object (File)
Sun, Mar 19, 4:24 PM
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
Test Plan

Tests are currently failing.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

anunay created this revision.Thu, Mar 16, 9:17 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptThu, Mar 16, 9:17 AM
Harbormaster completed remote builds in B17362: Diff 23788.Thu, Mar 16, 9:32 AM
anunay requested review of this revision.Thu, Mar 16, 9:32 AM
ashoat requested changes to this revision.Thu, Mar 16, 11:11 AM

We'll also need to update:

  1. https://github.com/CommE2E/comm/blob/master/native/package.json#L87 <-- this one is easy
  2. https://github.com/CommE2E/comm/blob/master/keyserver/package.json#L44 <-- probably easiest to publish our own version and just consume that
  3. https://github.com/CommE2E/comm/blob/master/web/package.json#L60 <-- probably easiest to publish our own version and just consume that

This is how to release: https://gitlab.matrix.org/matrix-org/olm#release-process

This revision now requires changes to proceed.Thu, Mar 16, 11:11 AM
ashoat added a comment.Thu, Mar 16, 11:11 AM

@anunay also talked about adding some JS tests, but we can sequence that later

ashoat added a child revision: D7089: [web][keyserver] Fork Olm.Thu, Mar 16, 6:41 PM
ashoat updated this revision to Diff 23810.Thu, Mar 16, 6:51 PM

Add keyserver types as well

ashoat accepted this revision.Thu, Mar 16, 6:59 PM

I handled my first comment in D7089, and added tests in D7090. I also updated this diff to include the libdef in keyserver

This revision is now accepted and ready to land.Thu, Mar 16, 6:59 PM
Harbormaster completed remote builds in B17377: Diff 23810.Thu, Mar 16, 7:11 PM
ashoat added inline comments.Thu, Mar 23, 8:02 AM
keyserver/flow-typed/npm/@matrix-org/olm_vx.x.x.js
35

Changes we might need here if we take the "caller owns rotation" approach:

  1. Change to the Account struct in C++ to track published time of the latest prekey
  2. Change to the PreKey struct in C++ to have a published boolean (could be merged with 1 by tracking publish_time on a PreKey basis)
  3. Either a new API for marking latest prekey as published, or use existing mark_keys_as_published API for this
  4. An API for getting the unpublished latest key. If the latest key is already published, it returns nothing
  5. An API for getting the publish time of the latest prekey

Revision Contents
Changeset List

PathSize
keyserver/
flow-typed/
npm/
@matrix-org/
4 lines
web/
flow-typed/
npm/
@matrix-org/
4 lines

Diff 23810

View Options

keyserver/flow-typed/npm/@matrix-org/olm_vx.x.x.js

Loading...
View Options

web/flow-typed/npm/@matrix-org/olm_vx.x.x.js

Loading...