Page MenuHomePhabricator

Amended Account & Session types.
ClosedPublic

Authored by anunay on Mar 16 2023, 9:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 2:00 AM
Unknown Object (File)
Fri, Mar 8, 1:34 AM
Unknown Object (File)
Tue, Mar 5, 11:39 PM
Unknown Object (File)
Tue, Mar 5, 11:39 PM
Unknown Object (File)
Tue, Mar 5, 11:39 PM
Unknown Object (File)
Tue, Mar 5, 11:39 PM
Unknown Object (File)
Feb 21 2024, 2:38 AM
Unknown Object (File)
Feb 13 2024, 2:39 AM
Subscribers

Details

Test Plan

Tests are currently failing.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat requested changes to this revision.Mar 16 2023, 11:11 AM

We'll also need to update:

  1. https://github.com/CommE2E/comm/blob/master/native/package.json#L87 <-- this one is easy
  2. https://github.com/CommE2E/comm/blob/master/keyserver/package.json#L44 <-- probably easiest to publish our own version and just consume that
  3. https://github.com/CommE2E/comm/blob/master/web/package.json#L60 <-- probably easiest to publish our own version and just consume that

This is how to release: https://gitlab.matrix.org/matrix-org/olm#release-process

This revision now requires changes to proceed.Mar 16 2023, 11:11 AM

@anunay also talked about adding some JS tests, but we can sequence that later

Add keyserver types as well

I handled my first comment in D7089, and added tests in D7090. I also updated this diff to include the libdef in keyserver

This revision is now accepted and ready to land.Mar 16 2023, 6:59 PM
keyserver/flow-typed/npm/@matrix-org/olm_vx.x.x.js
35

Changes we might need here if we take the "caller owns rotation" approach:

  1. Change to the Account struct in C++ to track published time of the latest prekey
  2. Change to the PreKey struct in C++ to have a published boolean (could be merged with 1 by tracking publish_time on a PreKey basis)
  3. Either a new API for marking latest prekey as published, or use existing mark_keys_as_published API for this
  4. An API for getting the unpublished latest key. If the latest key is already published, it returns nothing
  5. An API for getting the publish time of the latest prekey

Add signatures for @anunay's new methods

Two quick notes:

  1. I think we're still missing get_unpublished_prekey_json here – see my GitHub PR comment for more details
  2. This diff appears to modify the libdef for @matrix-org/olm, but in reality it only applies to @commapp/olm. Later diffs in this stack swap out the former for the latter, so this diff should not be landed without the rest of the diffs in the stack
This revision was automatically updated to reflect the committed changes.