Page MenuHomePhabricator

[native] Fork Olm
ClosedPublic

Authored by ashoat on Mar 16 2023, 7:34 PM.
Tags
None
Referenced Files
F2292414: D7091.diff
Tue, Jul 16, 9:36 PM
Unknown Object (File)
Mon, Jul 15, 2:39 PM
Unknown Object (File)
Sat, Jul 13, 6:49 PM
Unknown Object (File)
Sat, Jul 13, 1:36 PM
Unknown Object (File)
Sat, Jul 13, 5:40 AM
Unknown Object (File)
Mon, Jul 1, 12:01 AM
Unknown Object (File)
Mon, Jul 1, 12:01 AM
Unknown Object (File)
Mon, Jul 1, 12:01 AM
Subscribers
None

Details

Summary

This is the native counterpart to D7089.

Depends on D7089

Test Plan
  1. Unit tests are added in D7090
  2. Also note that we successfully ran Olm C++ and JS test suites
  3. I also patched the web app to confirm it worked
  4. Confirmed the iOS app builds

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/cpp/CommonCpp/CryptoTools/Session.cpp
32 ↗(On Diff #23816)

This is not great... we're doing pointer arithmetic on a vector's data, and using an offset based on the number of chars we need to seek into the JSON blob

Note that this code isn't actually used in production yet and wasn't referenced outside of the CryptoTest.mm file (deleted, more context on that in a separate comment)

native/ios/Comm.xcodeproj/project.pbxproj
991 ↗(On Diff #23816)

This might be controversial, but I deleted CryptoTest.mm. My understanding is that it's failing and I didn't really have context on why, but it's been failing for a while. It looks kind of messy and I'm not sure I have the cycles right now to fix it, and I don't want to block monthly goals on it. Open to creating a follow-up task if people want to keep this test around

This revision is now accepted and ready to land.Mar 17 2023, 12:49 PM
This revision was automatically updated to reflect the committed changes.