Page MenuHomePhabricator

Unit tests for Olm's new X3DH methods
ClosedPublic

Authored by ashoat on Mar 16 2023, 6:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 11, 5:24 PM
Unknown Object (File)
Sun, Feb 11, 5:24 PM
Unknown Object (File)
Sun, Feb 11, 5:23 PM
Unknown Object (File)
Sun, Feb 11, 5:23 PM
Unknown Object (File)
Sun, Feb 11, 5:23 PM
Unknown Object (File)
Sun, Feb 11, 5:23 PM
Unknown Object (File)
Sun, Feb 11, 5:22 PM
Unknown Object (File)
Sun, Feb 11, 2:10 PM
Subscribers

Details

Summary

This adds a quick test test to confirm Anunay's new methods work on web and keyserver that are introduced in the [fork](D7089).

Note that more extensive testing was done by updating the upstream tests in the fork, which include a Bob/Alice scenario in JavaScript.

Depends on D7091

Test Plan

Run the tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat added a reviewer: bartek.
ashoat added a subscriber: bartek.
ashoat added inline comments.
keyserver/jest-setup.js
1–8 ↗(On Diff #23811)

This is copied from web/jest-setup.js, introduced in D7019 by @bartek

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 16 2023, 7:04 PM
Harbormaster failed remote builds in B17378: Diff 23811!
ashoat edited the summary of this revision. (Show Details)
ashoat removed a parent revision: D7089: [web][keyserver] Fork Olm.
bartek added inline comments.
keyserver/src/utils/olm-utils.test.js
18 ↗(On Diff #23817)

You can possibly use toBeDefined or toBeTruthy here but up to you

This revision is now accepted and ready to land.Mar 21 2023, 4:37 AM