Page MenuHomePhabricator

[web][keyserver] Fork Olm

Authored by ashoat on Thu, Mar 16, 6:33 PM.
Referenced Files
F445689: D7089.diff
Sun, Mar 26, 1:25 AM
Unknown Object (File)
Wed, Mar 22, 10:54 AM
Unknown Object (File)
Wed, Mar 22, 10:32 AM
Unknown Object (File)
Tue, Mar 21, 11:02 AM
Unknown Object (File)
Mon, Mar 20, 10:40 AM
Unknown Object (File)
Mon, Mar 20, 3:28 AM
Unknown Object (File)
Mon, Mar 20, 3:28 AM
Unknown Object (File)
Mon, Mar 20, 3:28 AM



This switches us over to using a fork of Olm latest.

The fork is mostly Anunay's work to add X3DH support, plus @jon's work to add Nix build support for macOS, plus some fixes from me.

To review this you'll probably want to check the fork's commit history on GitHub. We should probably set up some way to review the stuff in the fork, but I'm not sure what the best approach is yet. For now, I've left comments directly on @anunay's commit on GitHub.

Test Plan
  1. Unit tests are added in D7090
  2. Also note that we successfully ran Olm C++ and JS test suites
  3. I also patched the web app to confirm it worked

Diff Detail

rCOMM Comm
No Lint Coverage
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Mar 16, 6:44 PM
Harbormaster failed remote builds in B17376: Diff 23809!

RE CI failure, looks like we need to update the xcode folder in the fork as well. Will publish this for review for now, but will definitely make sure to fix the xcode folder before landing

ashoat retitled this revision from Fork Olm to [web][keyserver] Fork Olm.Thu, Mar 16, 7:33 PM

Pulled out native side to D7091 since it turned out to be more work than expected

Update to 0.0.2... it doesn't actually affect web or keyserver, but I figure it's better to do it

This revision is now accepted and ready to land.Fri, Mar 17, 12:48 PM