Page MenuHomePhabricator
Differential D7116

[Comm-opaque2] Change project name to avoid name clash
ClosedPublic
Actions

Authored by • jon on Mar 20 2023, 10:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 14, 7:28 PM
Unknown Object (File)
Sun, Apr 14, 7:28 PM
Unknown Object (File)
Sun, Apr 14, 7:28 PM
Unknown Object (File)
Sun, Apr 14, 7:28 PM
Unknown Object (File)
Sun, Apr 14, 7:27 PM
Unknown Object (File)
Sun, Apr 14, 7:25 PM
Unknown Object (File)
Sat, Apr 6, 10:47 PM
Unknown Object (File)
Mar 8 2024, 1:36 AM
View All 74 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMce0700acc32b: [Comm-opaque2] Change project name to avoid name clash
Summary

Cargo requires the crate name to match the project
name

Part of https://linear.app/comm/issue/ENG-3263

Test Plan
cd services/identity
cargo build

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/identity-fix-name-clash
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Mar 20 2023, 10:22 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 20 2023, 10:22 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 20 2023, 10:27 PM
Harbormaster failed remote builds in B17455: Diff 23914!
• jon updated this revision to Diff 23959.Mar 21 2023, 12:32 PM

Copy comm-opaque2 in dockerfile

• jon added a child revision: D7130: [Identity] Add client device service to identity service.Mar 21 2023, 12:38 PM
Harbormaster completed remote builds in B17491: Diff 23959.Mar 21 2023, 12:51 PM
• jon requested review of this revision.Mar 21 2023, 12:51 PM
bartek accepted this revision.Mar 22 2023, 9:35 AM
This revision is now accepted and ready to land.Mar 22 2023, 9:35 AM
• jon updated this revision to Diff 24003.Mar 22 2023, 11:43 AM

Rebase on master

Harbormaster completed remote builds in B17533: Diff 24003.Mar 22 2023, 11:58 AM
varun accepted this revision.Mar 22 2023, 7:13 PM
Closed by commit rCOMMce0700acc32b: [Comm-opaque2] Change project name to avoid name clash (authored by • jon). · Explain WhyMar 23 2023, 8:06 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMce0700acc32b: [Comm-opaque2] Change project name to avoid name clash.

Revision Contents
Changeset List

PathSize
services/
identity/
1 line
shared/
comm-opaque2/
4 lines

Diff 23914

View Options

services/identity/Cargo.lock

Loading...
View Options

services/identity/Cargo.toml

Loading...
View Options

shared/comm-opaque2/Cargo.lock

Loading...
View Options

shared/comm-opaque2/Cargo.toml

Loading...