Paths

Table of Contentst

Differential D7170

[lib] Store encrypted messages in Client DB
ClosedPublic
Actions

Authored by bartek on Mar 24 2023, 5:29 AM.

Tags

None

Referenced Files

	F1671306: D7170.id24461.diff
	Sat, Apr 27, 9:00 PM

	F1671305: D7170.id24069.diff
	Sat, Apr 27, 9:00 PM

	F1671234: D7170.id.diff
	Sat, Apr 27, 8:56 PM

	F1671175: D7170.diff
	Sat, Apr 27, 8:29 PM

	Unknown Object (File)
	Mon, Apr 22, 8:13 AM

	Unknown Object (File)
	Tue, Apr 16, 8:33 AM

	Unknown Object (File)
	Tue, Apr 16, 7:54 AM

	Unknown Object (File)
	Tue, Apr 16, 12:07 AM

View All 61 Files

Subscribers

Details

Reviewers

kamil
atul
marcin

Commits

rCOMMa5d6dcf7b325: [lib] Store encrypted messages in Client DB

Summary

Part of ENG-3100

This diff adds support for storing encrypted media messages in client db.

I didn't modify the ClientDBMediaInfo type - it still contains only photo | video. Deduction if it is encrypted is based on existence of the encryption_key property. This approach works well, but I don't have strong opinion on it, I can refactor if requested.

Depends on D7169

Test Plan

Added unit tests. Also modified keyserver to compose encrypted media messaes and checked if they're properly saved and restored on native.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mar 24 2023, 5:29 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 24 2023, 5:29 AM

Harbormaster completed remote builds in B17581: Diff 24069.Mar 24 2023, 5:45 AM

bartek added a child revision: D7171: [keyserver] Compose encrypted media messages.Mar 24 2023, 5:59 AM

bartek published this revision for review.Mar 25 2023, 5:03 AM

Thanks for including aunt sets

This revision is now accepted and ready to land.Mar 28 2023, 4:14 PM

Closed by commit rCOMMa5d6dcf7b325: [lib] Store encrypted messages in Client DB (authored by bartek). · Explain WhyMar 30 2023, 11:45 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMa5d6dcf7b325: [lib] Store encrypted messages in Client DB.

Revision Contents
Changeset List

Path

Size

lib/

utils/

message-ops-utils.js

103 lines

message-ops-utils.test.js

97 lines

Diff 24461

lib/utils/message-ops-utils.js

Loading...

lib/utils/message-ops-utils.test.js

Loading...