web] introduce color-utils and move color functions from thread-utils to color-utils
ClosedPublic
Actions

Authored by ginsu on Mar 25 2023, 10:44 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMM35699428c66f: [keyserver/lib/native/web] introduce color-utils and move color functions from…

Summary

When working on D7178 I was getting the following error in keyserver:

Screenshot 2023-03-23 at 2.09.01 PM.png (1×3 px, 2 MB)

D7178 should offer more context, but the TLDR:

We use selectedThreadColor to build a default user emoji avatar, and we are trying to access selectedThreadColor before it gets initialized when we build this user avatar deeper in thread-utils

Test Plan

flow and the error messages in the keyserver logs no longer appear.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Mar 25 2023, 10:44 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 25 2023, 10:44 PM

ginsu edited the summary of this revision. (Show Details)Mar 25 2023, 10:58 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, atul.

ginsu attached a referenced file: F445414: Screenshot 2023-03-23 at 2.09.01 PM.png. (Show Details)

Harbormaster completed remote builds in B17635: Diff 24137.Mar 25 2023, 10:59 PM

ginsu requested review of this revision.Mar 25 2023, 10:59 PM

ginsu added a child revision: D7178: [lib] introduce getUserAvatarForThread function.Mar 25 2023, 11:35 PM

Looks like this is just a move diff so blindly accepting. Not familiar with that error myself, wondering what "initialization" means in this context (is it a circular dependency issue?)

This revision is now accepted and ready to land.Mar 26 2023, 5:43 AM