[lib] Reducer for commServicesAccessToken
ClosedPublic
Actions

Authored by ashoat on Mar 31 2023, 8:31 AM.

Details

Reviewers

kamil
varun
• jon
atul

Commits

rCOMMcda2f4166325: [lib] Reducer for commServicesAccessToken

Summary

Modelled this on lib/reducers/data-loaded-reducer.js.

Depends on D7241. Linear task: ENG-3389.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 31 2023, 8:31 AM

Herald added a subscriber: tomek. · View Herald TranscriptMar 31 2023, 8:31 AM

Harbormaster completed remote builds in B17891: Diff 24507.Mar 31 2023, 8:47 AM

ashoat requested review of this revision.Mar 31 2023, 8:47 AM

Makes sense.

(As an aside, do we think we'll be storing additional tokens in Redux in the future? Wondering if introducing a TokenStore or AccessTokenStore might save a migration in the future?)

This revision is now accepted and ready to land.Apr 2 2023, 4:10 PM

As an aside, do we think we'll be storing additional tokens in Redux in the future?

No such plans at the moment.

Closed by commit rCOMMcda2f4166325: [lib] Reducer for commServicesAccessToken (authored by ashoat). · Explain WhyApr 3 2023, 7:31 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMcda2f4166325: [lib] Reducer for commServicesAccessToken.

inka mentioned this in D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.Fri, Mar 29, 4:29 AM

Revision Contents
Changeset List

Path

Size

lib/

reducers/

master-reducer.js

5 lines

services-access-token-reducer.js

37 lines

Diff 24580

View Options

lib/reducers/master-reducer.js