[Comm-opaque2] Don't require mut self on register finish
ClosedPublic
Actions

Authored by • jon on Apr 7 2023, 1:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 5, 2:09 AM

	Unknown Object (File)
	Tue, Nov 5, 2:09 AM

	Unknown Object (File)
	Tue, Nov 5, 2:09 AM

	Unknown Object (File)
	Sun, Oct 27, 12:56 AM

	Unknown Object (File)
	Sun, Oct 27, 12:56 AM

	Unknown Object (File)
	Sun, Oct 27, 12:55 AM

	Unknown Object (File)
	Sun, Oct 27, 12:50 AM

	Unknown Object (File)
	Sep 26 2024, 1:14 PM

Subscribers

Details

Reviewers

varun
bartek

Commits

rCOMM90976770fa32: [Comm-opaque2] Don't require mut self on register finish

Summary

Small fixup, this was needed for opaque 1.2.0, but not
for opaque 2.0.

Test Plan

cd shared/comm-opaque2/
cargo test

Depends on D7299

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Apr 7 2023, 1:05 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 7 2023, 1:05 PM

Harbormaster completed remote builds in B18134: Diff 24836.Apr 7 2023, 1:21 PM

• jon requested review of this revision.Apr 7 2023, 1:21 PM

• jon added a child revision: D7365: [Identity] Register user on native client.Apr 7 2023, 1:33 PM

varun accepted this revision.Apr 7 2023, 1:40 PM

This revision is now accepted and ready to land.Apr 7 2023, 1:40 PM

Closed by commit rCOMM90976770fa32: [Comm-opaque2] Don't require mut self on register finish (authored by • jon). · Explain WhyApr 11 2023, 8:17 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM90976770fa32: [Comm-opaque2] Don't require mut self on register finish.

Revision Contents
Changeset List

Path

Size

shared/

comm-opaque2/

src/

server/

2 lines

Diff 24974

View Options

shared/comm-opaque2/src/server/register.rs

[Comm-opaque2] Don't require mut self on register finishClosedPublicActions