[Identity] Register user on native client
AbandonedPublic
Actions

Authored by • jon on Apr 7 2023, 1:16 PM.

Details

Reviewers

varun

Summary

WIP commit with most of the rust code written for
registering a user.

This is missing:

JS bindings
Pomotion from blocking to async rust
Modifying current register logic to receive access_token
Modifying keyserver logic to respect identity service access_token for session creation

Depends on D7299

Test Plan

Once the above bullet points are done:

nix develop

comm-dev services start
(cd services/identity && cargo run -- keygen)
(cd services/identity && cargo run -- server &)

# Run 'yarn dev' in keyserver/ and native/
# Attempt to create new user on native device

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/split-key-rpcs (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Apr 7 2023, 1:16 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 7 2023, 1:16 PM

Harbormaster completed remote builds in B18137: Diff 24839.Apr 7 2023, 1:32 PM

• jon requested review of this revision.Apr 7 2023, 1:32 PM

• jon edited parent revisions, added: D7362: [Comm-opaque2] Don't require mut self on register finish; removed: D7299: [Identity] Support keygen and server setup for opaque 2.0.Apr 7 2023, 1:33 PM

• jon added inline comments.Apr 7 2023, 1:43 PM

native/native_rust_library/src/lib.rs
160	Removed client as each RPC should be closing it's connections anyway. Also, having to directly communicate with identity should be infrequent, so I didn't think there was a meaningful use case for the connection to linger between actions.
services/identity/src/client_service.rs
145–155	This is a bit awkward, i agree. But we essentially need to look at the user information, then grab the devices, look at the first device, as a new user should only have one device then grab the key associated with it. The alternative (and I think cleaner) solution would be to have the device/X3DH information sent as part of the "finish" proto rpc, and then just use the information from the message. In this model, we would be updating the user with the password file (pakeRegistrationData), and adding a device.
services/identity/src/database.rs
287	a lot of these functions in src/database.rs haven't been properly tested. Might need some addtional work
575	this should probably force `consistent_read(true)`, to ensure there's no other pending writes at the time.
958	I created a testcase to ensure this is likely to never get triggered.